Attention is currently required from: Tarun Tuli, Derek Huang, Caveh Jalali, Nick Vaccaro, Daisuke Nojiri, Boris Mittelberg.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70773 )
Change subject: src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9:
looking at the variant.c files, I felt the implementation is copied across (isn't it)?
Instead, I would recommend introducing a Kconfig like CLEAR_EC_AP_IDLE_FLAG and perform the required operations inside the mainboard.c file alone. The target chrombox designs would only select CLEAR_EC_AP_IDLE_FLAG. This will ensure the changes only impact the chromebox and brya/nissa/skolas are not getting impacted.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70773
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b
Gerrit-Change-Number: 70773
Gerrit-PatchSet: 9
Gerrit-Owner: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Mon, 02 Jan 2023 15:34:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment