Attention is currently required from: Michał Żygowski, Christian Walter, Julius Werner, Krystian Hebel.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69023 )
Change subject: drivers/pc80/tpm: probe for TPM family of a device ......................................................................
Patch Set 3:
(3 comments)
File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/69023/comment/0091d4bd_0e70cc2e PS2, Line 97: int tpm_family;
I think it might be nice to make an enum for this (especially since you start using it more widely i […]
Done
https://review.coreboot.org/c/coreboot/+/69023/comment/4834e535_06b53ce2 PS2, Line 392: const char *vendor_name = device_name;
Why not just initialize these to NULL now so you don't have to strcmp?
Done
https://review.coreboot.org/c/coreboot/+/69023/comment/1dc59bf8_a7b72b82 PS2, Line 435: return TPM_DRIVER_ERR;
This is a pretty big change in behavior (refusing to support anything not in the list). […]
It is a big change and I might have got it wrong. Michał wrote in https://ticket.coreboot.org/issues/433 about multiple probe functions succeeding in which case there might be an ambiguity with regard to TPM version, so I made the check stricter here. However, since the next change returns TPM family, shouldn't that be enough to know which TSS implementation to use?
-
Sergii Dmytruk (Code Review)