Attention is currently required from: Arthur Heymans, Caveh Jalali, Cliff Huang, Felix Singer, Julius Werner, Martin L Roth, Matt DeVillier, Yu-Ping Wu.
Hello Arthur Heymans, Caveh Jalali, Christian Walter, Cliff Huang, Felix Held, Felix Singer, Forest Mittelberg, Fred Reitberger, Hung-Te Lin, Jakub Czapiga, Jason Glenesk, Jeff Daly, Johnny Lin, Jonathan Zhang, Julius Werner, Lance Zhao, Matt DeVillier, Matt DeVillier, Raul Rangel, Sean Rhodes, Tim Chu, Tim Wawrzynczak, Vanessa Eusebio, Xi Chen, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/77098?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed: Code-Review+1 by Felix Singer, Code-Review+1 by Matt DeVillier, Code-Review+1 by Yu-Ping Wu, Verified+1 by build bot (Jenkins)
Change subject: treewide: Change I2C/SMBUS master/slave to controller/target ......................................................................
treewide: Change I2C/SMBUS master/slave to controller/target
The I2C and SMBUS specifications have updated their terminology from master/slave to controller/target. As stated in the coreboot language style page, using the word 'slave' should be avoided when possible [1] except when discussing the term as applicable by the current standards.
As the SMBUS and I2C standards are no longer using this terminology, the updated terms controller/target should be used in the coreboot I2C/SMBUS code.
We'll keep register names for devices are they are in the datasheets.
[1] https://doc.coreboot.org/community/language_style.html#discussing-words-to-r...
Signed-off-by: Martin Roth gaumless@gmail.com Change-Id: I6c141fa4322de9e9ed208589f591560fed609825 --- M Documentation/technotes/console.md M Documentation/tutorial/part3.md M src/acpi/device.c M src/commonlib/bsd/include/commonlib/bsd/cb_err.h M src/console/Kconfig M src/device/dram/rcd.c M src/device/i2c_bus.c M src/device/software_i2c.c M src/drivers/analogix/anx7625/anx7625.c M src/drivers/i2c/designware/dw_i2c.c M src/drivers/i2c/tpm/tpm.c M src/drivers/i2c/ww_ring/ww_ring.c M src/drivers/intel/gma/edid.c M src/drivers/intel/gma/edid.h M src/drivers/smbus/i2c_smbus_console.c M src/drivers/smbus/sc16is7xx_init.c M src/ec/google/chromeec/ec_i2c.c M src/ec/kontron/kempld/kempld_i2c.c M src/include/device/i2c.h M src/include/device/i2c_bus.h M src/include/device/i2c_simple.h M src/include/device/smbus_host.h M src/include/smbios.h M src/lib/smbios.c M src/mainboard/asus/p8x7x-series/variants/p8c_ws/overridetree.cb M src/mainboard/google/auron/variants/auron_paine/include/variant/acpi/mainboard.asl M src/mainboard/google/auron/variants/auron_yuna/include/variant/acpi/mainboard.asl M src/mainboard/google/auron/variants/buddy/include/variant/acpi/mainboard.asl M src/mainboard/google/auron/variants/gandof/include/variant/acpi/mainboard.asl M src/mainboard/google/auron/variants/lulu/include/variant/acpi/mainboard.asl M src/mainboard/google/auron/variants/samus/include/variant/acpi/mainboard.asl M src/mainboard/google/cyan/acpi/touchscreen_elan.asl M src/mainboard/google/cyan/acpi/touchscreen_melfas.asl M src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl M src/mainboard/google/cyan/acpi/trackpad_atmel.asl M src/mainboard/google/cyan/acpi/trackpad_elan.asl M src/mainboard/google/daisy/exynos5250.h M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/kukui/boardid.c M src/mainboard/google/octopus/variants/baseboard/devicetree.cb M src/mainboard/google/rambi/acpi/mainboard.asl M src/mainboard/google/rambi/acpi/touchscreen_atmel.asl M src/mainboard/google/rambi/acpi/touchscreen_elan.asl M src/mainboard/google/rambi/acpi/touchscreen_wdt.asl M src/mainboard/google/rambi/acpi/trackpad_atmel.asl M src/mainboard/google/rambi/acpi/trackpad_elan.asl M src/mainboard/google/slippy/variants/falco/include/variant/acpi/mainboard.asl M src/mainboard/google/slippy/variants/leon/include/variant/acpi/mainboard.asl M src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl M src/mainboard/google/slippy/variants/wolf/include/variant/acpi/mainboard.asl M src/mainboard/intel/glkrvp/touchpad.asl M src/mainboard/intel/strago/acpi/mainboard.asl M src/northbridge/intel/i945/gma.c M src/soc/amd/stoneyridge/smbus_spd.c M src/soc/cavium/cn81xx/twsi.c M src/soc/cavium/common/bdk-coreboot.c M src/soc/intel/apollolake/chip.h M src/soc/intel/baytrail/scc.c M src/soc/intel/common/block/include/intelblocks/imc.h M src/soc/intel/common/block/smbus/smbus.c M src/soc/mediatek/common/i2c.c M src/soc/nvidia/tegra/i2c.c M src/soc/qualcomm/common/qupv3_i2c.c M src/soc/qualcomm/ipq40xx/i2c.c M src/soc/qualcomm/ipq806x/i2c.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/rockchip/common/i2c.c M src/soc/samsung/exynos5250/i2c.c M src/soc/samsung/exynos5420/i2c.c M src/southbridge/amd/pi/hudson/smbus_spd.c M src/southbridge/intel/bd82x6x/smbus.c M src/southbridge/intel/common/smbus.c M src/southbridge/intel/ibexpeak/smbus.c M src/southbridge/intel/lynxpoint/smbus.c M tests/device/i2c-test.c M util/intelvbttool/intelvbttool.c 76 files changed, 274 insertions(+), 274 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/77098/5