[S] Change in coreboot[main]: mb/google/fatcat/variants/fatcat: Enable BT audio offload

[Pranava Y N (Code Review)]

Attention is currently required from: Jayvik Desai, Kapil Porwal, Subrata Banik, Uday Bhat.

Pranava Y N has posted comments on this change by Uday Bhat. ( https://review.coreboot.org/c/coreboot/+/86121?usp=email )

Change subject: mb/google/fatcat/variants/fatcat: Enable BT audio offload
......................................................................

Patch Set 1:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/86121/comment/e6417c6d_919259b6?usp... :
PS1, Line 12: I2S and soundwire
What about HDA configuration?

File src/mainboard/google/fatcat/variants/fatcat/fw_config.c:

https://review.coreboot.org/c/coreboot/+/86121/comment/e0adadfc_def0ec5a?usp... :
PS1, Line 88: static const struct pad_config bt_i2s_enable_pads[] = {
Disable these pads in `AUDIO_NONE` configuration?

https://review.coreboot.org/c/coreboot/+/86121/comment/5ab0c58d_c1ba4099?usp... :
PS1, Line 578: 	else if (fw_config_probe(FW_CONFIG(AUDIO, AUDIO_ALC256_HDA))) {
> `else should follow close brace '}'`

Please fix.

File src/mainboard/google/fatcat/variants/fatcat/variant.c:

https://review.coreboot.org/c/coreboot/+/86121/comment/0f49eacd_dd85ffb5?usp... :
PS1, Line 17: 	printk(BIOS_INFO, "Configure BT audio offload config.\n");
This log message seems redundant.

https://review.coreboot.org/c/coreboot/+/86121/comment/ad9b767a_e45cae67?usp... :
PS1, Line 24: config->cnvi_bt_audio_offload = true;
Shouldn't setting this also depend on the `AUDIO` configs?