Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42574 )
Change subject: mb/gigabyte/ga-945gcm-s2l: don't select HAVE_MP_TABLE ......................................................................
mb/gigabyte/ga-945gcm-s2l: don't select HAVE_MP_TABLE
Both variants have no mptable.c, but select HAVE_MP_TABLE, which should only be selected if they provided a mptable.c.
Change-Id: I0ba06638d7ed0a9cd0f1ae41a8db45b79602418a Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/42574/1
diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig b/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig index 9a8bf5b..56671c7 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig @@ -11,7 +11,6 @@ select SUPERIO_ITE_IT8718F select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT - select HAVE_MP_TABLE select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_512
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42574 )
Change subject: mb/gigabyte/ga-945gcm-s2l: don't select HAVE_MP_TABLE ......................................................................
Patch Set 1: Code-Review+2
Felix Held has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42574 )
Change subject: mb/gigabyte/ga-945gcm-s2l: don't select HAVE_MP_TABLE ......................................................................
Abandoned
this changes behaviour due to a weak definition of write_smp_table()
-
Angel Pons (Code Review) -
Felix Held (Code Review)