Change in ...coreboot[master]: G505S dGPU support: scripts for applying the unofficial (not-merged-y...
Hello Mike Banon,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31929
to review the following change.
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) updates ......................................................................
G505S dGPU support: scripts for applying the unofficial (not-merged-yet) updates
These scripts will help you to securely and conveniently apply the three changes 31357, 31448, 31450 to add the discrete GPU support for AMD Lenovo G505S laptop. Save to ./coreboot/ then run ./get_dgpu_patches.sh , ./check... and ./apply...
https://review.coreboot.org/c/coreboot/+/31357 src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
https://review.coreboot.org/c/coreboot/+/31448 src/device/pci: Add support for discrete VGA initialization and OpROM loading
https://review.coreboot.org/c/coreboot/+/31450 lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I956f360681762b4321ba5d967f8a27b4a0387a73 --- A apply_dgpu_patches.sh A check_dgpu_patches.sh A get_dgpu_patches.sh A sha256sums_dgpu_correct.txt 4 files changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/31929/1
diff --git a/apply_dgpu_patches.sh b/apply_dgpu_patches.sh new file mode 100755 index 0000000..972800a --- /dev/null +++ b/apply_dgpu_patches.sh @@ -0,0 +1,16 @@ +#!/bin/sh +### +### https://review.coreboot.org/c/coreboot/+/31357 +### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware +### +patch -p1 < f5c1e4d.diff +### +### https://review.coreboot.org/c/coreboot/+/31448 +### src/device/pci: Add support for discrete VGA initialization and OpROM loading +### +patch -p1 < 828c74a.diff +### +### https://review.coreboot.org/c/coreboot/+/31450 +### lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop +### +patch -p1 < 54dd729.diff diff --git a/check_dgpu_patches.sh b/check_dgpu_patches.sh new file mode 100755 index 0000000..cae1e9f --- /dev/null +++ b/check_dgpu_patches.sh @@ -0,0 +1,11 @@ +#!/bin/sh +rm -f ./sha256sums_dgpu_my.txt +sha256sum ./f5c1e4d.diff > ./sha256sums_dgpu_my.txt +sha256sum ./828c74a.diff >> ./sha256sums_dgpu_my.txt +sha256sum ./54dd729.diff >> ./sha256sums_dgpu_my.txt +if cmp -s "./sha256sums_dgpu_my.txt" "./sha256sums_dgpu_correct.txt" +then + echo "SHA256 checksums are correct, please run ./apply_dgpu_patches.sh" +else + echo "! MISMATCH ! See ./sha256sums_dgpu_my.txt and ./sha256sums_dgpu_correct.txt" +fi diff --git a/get_dgpu_patches.sh b/get_dgpu_patches.sh new file mode 100755 index 0000000..c1703df --- /dev/null +++ b/get_dgpu_patches.sh @@ -0,0 +1,20 @@ +#!/bin/sh +rm -f ./*.diff && rm -f ./patch?zip +### +### https://review.coreboot.org/c/coreboot/+/31357 +### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware +### +wget https://review.coreboot.org/changes/31357/revisions/6/patch?zip +unzip ./patch?zip && rm -f ./patch?zip # && patch -p1 < f5c1e4d.diff +### +### https://review.coreboot.org/c/coreboot/+/31448 +### src/device/pci: Add support for discrete VGA initialization and OpROM loading +### +wget https://review.coreboot.org/changes/31448/revisions/8/patch?zip +unzip ./patch?zip && rm -f ./patch?zip # && patch -p1 < 828c74a.diff +### +### https://review.coreboot.org/c/coreboot/+/31450 +### lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop +### +wget https://review.coreboot.org/changes/31450/revisions/8/patch?zip +unzip ./patch?zip && rm -f ./patch?zip # && patch -p1 < 54dd729.diff diff --git a/sha256sums_dgpu_correct.txt b/sha256sums_dgpu_correct.txt new file mode 100644 index 0000000..b519a6a --- /dev/null +++ b/sha256sums_dgpu_correct.txt @@ -0,0 +1,3 @@ +1e6dff37ae1b8080c431f25b7a12c561bd949dfa68f6487a1bece39941f74195 ./f5c1e4d.diff +1879c633478c105eb9d66afa97fc59db0c850a813d4bcdb3693a6f52645092d8 ./828c74a.diff +a055e0d1fff668b95da68b7b6c7274d000bbf90572747b4f33de7f5f59a5bb44 ./54dd729.diff
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) updates ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/31929/1/apply_dgpu_patches.sh File apply_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/1/apply_dgpu_patches.sh@4 PS1, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/1/apply_dgpu_patches.sh@9 PS1, Line 9: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
https://review.coreboot.org/#/c/31929/1/check_dgpu_patches.sh File check_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/1/check_dgpu_patches.sh@10 PS1, Line 10: echo "! MISMATCH ! See ./sha256sums_dgpu_my.txt and ./sha256sums_dgpu_correct.txt" line over 80 characters
https://review.coreboot.org/#/c/31929/1/get_dgpu_patches.sh File get_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/1/get_dgpu_patches.sh@5 PS1, Line 5: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/1/get_dgpu_patches.sh@11 PS1, Line 11: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) updates ......................................................................
Patch Set 1: Code-Review-2
I don't mind the purpose of documentation. The scripts are bound to fail as soon as one pulls a fresh master and tries to apply the patches.
mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) updates ......................................................................
Patch Set 1: Code-Review+1
Patch Set 1: Code-Review-2
I don't mind the purpose of documentation. The scripts are bound to fail as soon as one pulls a fresh master and tries to apply the patches.
I know, but no problem: when it happens, I will update these dGPU patches to make them compatible again, and then update the scripts (links to the latest revisions + checksums which will also change).
Hello Kyösti Mälkki, Mike Banon, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31929
to look at the new patch set (#2).
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches
These scripts will help you to securely and conveniently apply the three changes 31357, 31448, 31450 to add the discrete GPU support for AMD Lenovo G505S laptop. Save to ./coreboot/ then run ./get_dgpu_patches.sh , ./check... and ./apply...
https://review.coreboot.org/c/coreboot/+/31357 src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
https://review.coreboot.org/c/coreboot/+/31448 src/device/pci: Add support for discrete VGA initialization and OpROM loading
https://review.coreboot.org/c/coreboot/+/31450 lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I956f360681762b4321ba5d967f8a27b4a0387a73 --- A apply_dgpu_patches.sh A check_dgpu_patches.sh A get_dgpu_patches.sh A sha256sums_dgpu_correct.txt 4 files changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/31929/2
Hello Kyösti Mälkki, Mike Banon, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31929
to look at the new patch set (#3).
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches
These scripts will help you to securely and conveniently apply the three changes 31357, 31448, 31450 to add the discrete GPU support for AMD Lenovo G505S laptop. Save to ./coreboot/ then run ./get_dgpu_patches.sh , ./check... and ./apply...
https://review.coreboot.org/c/coreboot/+/31357 src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
https://review.coreboot.org/c/coreboot/+/31448 src/device/pci: Add support for discrete VGA initialization and OpROM loading
https://review.coreboot.org/c/coreboot/+/31450 lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I956f360681762b4321ba5d967f8a27b4a0387a73 --- A apply_dgpu_patches.sh A check_dgpu_patches.sh A get_dgpu_patches.sh A sha256sums_dgpu_correct.txt 4 files changed, 51 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/31929/3
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/#/c/31929/3/apply_dgpu_patches.sh File apply_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/3/apply_dgpu_patches.sh@4 PS3, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/3/apply_dgpu_patches.sh@9 PS3, Line 9: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
https://review.coreboot.org/#/c/31929/3/check_dgpu_patches.sh File check_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/3/check_dgpu_patches.sh@10 PS3, Line 10: echo "! MISMATCH ! See ./sha256sums_dgpu_my.txt and ./sha256sums_dgpu_correct.txt" line over 80 characters
https://review.coreboot.org/#/c/31929/3/get_dgpu_patches.sh File get_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/3/get_dgpu_patches.sh@5 PS3, Line 5: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/3/get_dgpu_patches.sh@11 PS3, Line 11: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
Hello Kyösti Mälkki, Mike Banon, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31929
to look at the new patch set (#4).
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches
These scripts will help you to securely and conveniently apply the three changes 31357, 31448, 31450 to add the discrete GPU support for AMD Lenovo G505S laptop. Save to ./coreboot/ then run ./get_dgpu_patches.sh , ./check... and ./apply...
https://review.coreboot.org/c/coreboot/+/31357 src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
https://review.coreboot.org/c/coreboot/+/31448 src/device/pci: Add support for discrete VGA initialization and OpROM loading
https://review.coreboot.org/c/coreboot/+/31450 lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I956f360681762b4321ba5d967f8a27b4a0387a73 --- A apply_dgpu_patches.sh A check_dgpu_patches.sh A get_dgpu_patches.sh A sha256sums_dgpu_correct.txt 4 files changed, 52 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/31929/4
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/#/c/31929/4/apply_dgpu_patches.sh File apply_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/4/apply_dgpu_patches.sh@4 PS4, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/4/apply_dgpu_patches.sh@9 PS4, Line 9: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
https://review.coreboot.org/#/c/31929/4/check_dgpu_patches.sh File check_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/4/check_dgpu_patches.sh@11 PS4, Line 11: echo "! MISMATCH ! See ./sha256sums_dgpu_my.txt and ./sha256sums_dgpu_correct.txt" line over 80 characters
https://review.coreboot.org/#/c/31929/4/get_dgpu_patches.sh File get_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/4/get_dgpu_patches.sh@5 PS4, Line 5: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/4/get_dgpu_patches.sh@11 PS4, Line 11: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Patch Set 4: Code-Review+1
Added the return values to "check_dgpu_patches.sh" script.
Hello Kyösti Mälkki, Mike Banon, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31929
to look at the new patch set (#5).
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches
These scripts will help you to securely and conveniently apply the three changes 31357, 31448, 31450 to add the discrete GPU support for AMD Lenovo G505S laptop. Save to ./coreboot/ then run ./get_dgpu_patches.sh , ./check... and ./apply...
https://review.coreboot.org/c/coreboot/+/31357 src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
https://review.coreboot.org/c/coreboot/+/31448 src/device/pci: Add support for discrete VGA initialization and OpROM loading
https://review.coreboot.org/c/coreboot/+/31450 lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I956f360681762b4321ba5d967f8a27b4a0387a73 --- A apply_dgpu_patches.sh A check_dgpu_patches.sh A get_dgpu_patches.sh A sha256sums_dgpu_correct.txt 4 files changed, 52 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/31929/5
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/#/c/31929/5/apply_dgpu_patches.sh File apply_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/5/apply_dgpu_patches.sh@4 PS5, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/5/apply_dgpu_patches.sh@9 PS5, Line 9: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
https://review.coreboot.org/#/c/31929/5/check_dgpu_patches.sh File check_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/5/check_dgpu_patches.sh@11 PS5, Line 11: echo "! MISMATCH ! See ./sha256sums_dgpu_my.txt and ./sha256sums_dgpu_correct.txt" line over 80 characters
https://review.coreboot.org/#/c/31929/5/get_dgpu_patches.sh File get_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/5/get_dgpu_patches.sh@5 PS5, Line 5: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/5/get_dgpu_patches.sh@11 PS5, Line 11: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/#/c/31929/6/apply_dgpu_patches.sh File apply_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/6/apply_dgpu_patches.sh@4 PS6, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/6/apply_dgpu_patches.sh@9 PS6, Line 9: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
https://review.coreboot.org/#/c/31929/6/check_dgpu_patches.sh File check_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/6/check_dgpu_patches.sh@11 PS6, Line 11: echo "! MISMATCH ! See ./sha256sums_dgpu_my.txt and ./sha256sums_dgpu_correct.txt" line over 80 characters
https://review.coreboot.org/#/c/31929/6/get_dgpu_patches.sh File get_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/6/get_dgpu_patches.sh@5 PS6, Line 5: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/6/get_dgpu_patches.sh@11 PS6, Line 11: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Patch Set 6:
For those who is coming there from the Internet, these dGPU patches help to resolve the following problem observed while running Linux on G505S with coreboot BIOS installed:
[ Time_1] [drm:radeon_get_bios [radeon]] *ERROR* ACPI VFCT image header truncated [ Time_2] radeon 0000:01:00.0: Invalid PCI ROM header signature: expecting 0xaa55, got 0x0000 [ Time_3] radeon 0000:01:00.0: Invalid PCI ROM header signature: expecting 0xaa55, got 0x0000 [ Time_4] [drm:radeon_get_bios [radeon]] *ERROR* Unable to locate a BIOS ROM [ Time_5] radeon 0000:01:00.0: Fatal error during GPU init [ Time_6] [drm] radeon: finishing device.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/#/c/31929/7/apply_dgpu_patches.sh File apply_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/7/apply_dgpu_patches.sh@4 PS7, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/7/apply_dgpu_patches.sh@9 PS7, Line 9: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
https://review.coreboot.org/#/c/31929/7/check_dgpu_patches.sh File check_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/7/check_dgpu_patches.sh@11 PS7, Line 11: echo "! MISMATCH ! See ./sha256sums_dgpu_my.txt and ./sha256sums_dgpu_correct.txt" line over 80 characters
https://review.coreboot.org/#/c/31929/7/get_dgpu_patches.sh File get_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/7/get_dgpu_patches.sh@5 PS7, Line 5: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/7/get_dgpu_patches.sh@11 PS7, Line 11: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
Hello Kyösti Mälkki, Mike Banon, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31929
to look at the new patch set (#8).
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches
These scripts will help you to securely and conveniently apply the three changes 31357, 31448, 31450 to add the discrete GPU support for AMD Lenovo G505S laptop. Save to ./coreboot/ then run ./get_dgpu_patches.sh , ./check... and ./apply...
https://review.coreboot.org/c/coreboot/+/31357 src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
https://review.coreboot.org/c/coreboot/+/31448 src/device/pci: Add support for discrete VGA initialization and OpROM loading
https://review.coreboot.org/c/coreboot/+/31450 lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I956f360681762b4321ba5d967f8a27b4a0387a73 --- A apply_dgpu_patches.sh A check_dgpu_patches.sh A get_dgpu_patches.sh A sha256sums_dgpu_correct.txt 4 files changed, 51 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/31929/8
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/#/c/31929/8/apply_dgpu_patches.sh File apply_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/8/apply_dgpu_patches.sh@4 PS8, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/8/apply_dgpu_patches.sh@9 PS8, Line 9: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
https://review.coreboot.org/#/c/31929/8/check_dgpu_patches.sh File check_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/8/check_dgpu_patches.sh@11 PS8, Line 11: echo "! MISMATCH ! See ./sha256sums_dgpu_my.txt and ./sha256sums_dgpu_correct.txt" line over 80 characters
https://review.coreboot.org/#/c/31929/8/get_dgpu_patches.sh File get_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/8/get_dgpu_patches.sh@4 PS8, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/8/get_dgpu_patches.sh@10 PS8, Line 10: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
Hello Kyösti Mälkki, Mike Banon, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31929
to look at the new patch set (#9).
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches
These scripts will help you to securely and conveniently apply the three changes 31357, 31448, 31450 to add the discrete GPU support for AMD Lenovo G505S laptop. Save to ./coreboot/ then run ./get_dgpu_patches.sh , ./check... and ./apply...
https://review.coreboot.org/c/coreboot/+/31357 src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
https://review.coreboot.org/c/coreboot/+/31448 src/device/pci: Add support for discrete VGA initialization and OpROM loading
https://review.coreboot.org/c/coreboot/+/31450 lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I956f360681762b4321ba5d967f8a27b4a0387a73 --- A apply_dgpu_patches.sh A check_dgpu_patches.sh A get_dgpu_patches.sh A sha256sums_dgpu_correct.txt 4 files changed, 54 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/31929/9
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Patch Set 9:
(5 comments)
https://review.coreboot.org/#/c/31929/9/apply_dgpu_patches.sh File apply_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/9/apply_dgpu_patches.sh@4 PS9, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/9/apply_dgpu_patches.sh@9 PS9, Line 9: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
https://review.coreboot.org/#/c/31929/9/check_dgpu_patches.sh File check_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/9/check_dgpu_patches.sh@11 PS9, Line 11: echo "! MISMATCH ! See ./sha256sums_dgpu_my.txt and ./sha256sums_dgpu_correct.txt" line over 80 characters
https://review.coreboot.org/#/c/31929/9/get_dgpu_patches.sh File get_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/9/get_dgpu_patches.sh@4 PS9, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/9/get_dgpu_patches.sh@11 PS9, Line 11: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
Hello Kyösti Mälkki, Mike Banon, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31929
to look at the new patch set (#10).
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches
These scripts will help you to securely and conveniently apply the three changes 31357, 31448, 31450 to add the discrete GPU support for AMD Lenovo G505S laptop. Save to ./coreboot/ then run ./get_dgpu_patches.sh , ./check... and ./apply...
https://review.coreboot.org/c/coreboot/+/31357 src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
https://review.coreboot.org/c/coreboot/+/31448 src/device/pci: Add support for discrete VGA initialization and OpROM loading
https://review.coreboot.org/c/coreboot/+/31450 lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I956f360681762b4321ba5d967f8a27b4a0387a73 --- A apply_dgpu_patches.sh A check_dgpu_patches.sh A get_dgpu_patches.sh A sha256sums_dgpu_correct.txt 4 files changed, 54 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/31929/10
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Patch Set 10:
(5 comments)
https://review.coreboot.org/#/c/31929/10/apply_dgpu_patches.sh File apply_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/10/apply_dgpu_patches.sh@4 PS10, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/10/apply_dgpu_patches.sh@9 PS10, Line 9: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
https://review.coreboot.org/#/c/31929/10/check_dgpu_patches.sh File check_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/10/check_dgpu_patches.sh@11 PS10, Line 11: echo "! MISMATCH ! See ./sha256sums_dgpu_my.txt and ./sha256sums_dgpu_correct.txt" line over 80 characters
https://review.coreboot.org/#/c/31929/10/get_dgpu_patches.sh File get_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/10/get_dgpu_patches.sh@4 PS10, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/10/get_dgpu_patches.sh@11 PS10, Line 11: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
Hello Kyösti Mälkki, Mike Banon, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31929
to look at the new patch set (#11).
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches
These scripts will help you to securely and conveniently apply the three changes 31357, 31448, 31450 to add the discrete GPU support for AMD Lenovo G505S laptop. Save to ./coreboot/ then run ./get_dgpu_patches.sh , ./check... and ./apply...
https://review.coreboot.org/c/coreboot/+/31357 src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
https://review.coreboot.org/c/coreboot/+/31448 src/device/pci: Add support for discrete VGA initialization and OpROM loading
https://review.coreboot.org/c/coreboot/+/31450 lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I956f360681762b4321ba5d967f8a27b4a0387a73 --- A apply_dgpu_patches.sh A check_dgpu_patches.sh A get_dgpu_patches.sh A sha256sums_dgpu_correct.txt 4 files changed, 54 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/31929/11
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Patch Set 11:
(5 comments)
https://review.coreboot.org/#/c/31929/11/apply_dgpu_patches.sh File apply_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/11/apply_dgpu_patches.sh@4 PS11, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/11/apply_dgpu_patches.sh@9 PS11, Line 9: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
https://review.coreboot.org/#/c/31929/11/check_dgpu_patches.sh File check_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/11/check_dgpu_patches.sh@11 PS11, Line 11: echo "! MISMATCH ! See ./sha256sums_dgpu_my.txt and ./sha256sums_dgpu_correct.txt" line over 80 characters
https://review.coreboot.org/#/c/31929/11/get_dgpu_patches.sh File get_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/11/get_dgpu_patches.sh@4 PS11, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/11/get_dgpu_patches.sh@11 PS11, Line 11: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Patch Set 12:
(5 comments)
https://review.coreboot.org/#/c/31929/12/apply_dgpu_patches.sh File apply_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/12/apply_dgpu_patches.sh@4 PS12, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/12/apply_dgpu_patches.sh@9 PS12, Line 9: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
https://review.coreboot.org/#/c/31929/12/check_dgpu_patches.sh File check_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/12/check_dgpu_patches.sh@11 PS12, Line 11: echo "! MISMATCH ! See ./sha256sums_dgpu_my.txt and ./sha256sums_dgpu_correct.txt" line over 80 characters
https://review.coreboot.org/#/c/31929/12/get_dgpu_patches.sh File get_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/12/get_dgpu_patches.sh@4 PS12, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/12/get_dgpu_patches.sh@11 PS12, Line 11: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
Hello Kyösti Mälkki, Mike Banon, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31929
to look at the new patch set (#13).
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches
These scripts will help you to securely and conveniently apply the three changes 31357, 31448, 31450 to add the discrete GPU support for AMD Lenovo G505S laptop. Save to ./coreboot/ then run ./get_dgpu_patches.sh , ./check... and ./apply...
https://review.coreboot.org/c/coreboot/+/31357 src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
https://review.coreboot.org/c/coreboot/+/31448 src/device/pci: Add support for discrete VGA initialization and OpROM loading
https://review.coreboot.org/c/coreboot/+/31450 lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I956f360681762b4321ba5d967f8a27b4a0387a73 --- A apply_dgpu_patches.sh A check_dgpu_patches.sh A get_dgpu_patches.sh A sha256sums_dgpu_correct.txt 4 files changed, 54 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/31929/13
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Patch Set 13:
(5 comments)
https://review.coreboot.org/#/c/31929/13/apply_dgpu_patches.sh File apply_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/13/apply_dgpu_patches.sh@4 PS13, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/13/apply_dgpu_patches.sh@9 PS13, Line 9: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
https://review.coreboot.org/#/c/31929/13/check_dgpu_patches.sh File check_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/13/check_dgpu_patches.sh@11 PS13, Line 11: echo "! MISMATCH ! See ./sha256sums_dgpu_my.txt and ./sha256sums_dgpu_correct.txt" line over 80 characters
https://review.coreboot.org/#/c/31929/13/get_dgpu_patches.sh File get_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/13/get_dgpu_patches.sh@4 PS13, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/13/get_dgpu_patches.sh@11 PS13, Line 11: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
Hello Kyösti Mälkki, Mike Banon, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31929
to look at the new patch set (#14).
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches
These scripts will help you to securely and conveniently apply the three changes 31357, 31448, 31450 to add the discrete GPU support for AMD Lenovo G505S laptop. Save to ./coreboot/ then run ./get_dgpu_patches.sh , ./check... and ./apply...
https://review.coreboot.org/c/coreboot/+/33870 src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
https://review.coreboot.org/c/coreboot/+/33871 src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware
https://review.coreboot.org/c/coreboot/+/31448 src/device/pci: Add support for discrete VGA initialization and OpROM loading
https://review.coreboot.org/c/coreboot/+/31450 lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I956f360681762b4321ba5d967f8a27b4a0387a73 --- A apply_dgpu_patches.sh A check_dgpu_patches.sh A get_dgpu_patches.sh A sha256sums_dgpu_correct.txt 4 files changed, 71 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/31929/14
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Patch Set 14:
(5 comments)
https://review.coreboot.org/#/c/31929/14/apply_dgpu_patches.sh File apply_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/14/apply_dgpu_patches.sh@4 PS14, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/14/apply_dgpu_patches.sh@14 PS14, Line 14: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
https://review.coreboot.org/#/c/31929/14/check_dgpu_patches.sh File check_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/14/check_dgpu_patches.sh@12 PS14, Line 12: echo "! MISMATCH ! See ./sha256sums_dgpu_my.txt and ./sha256sums_dgpu_correct.txt" line over 80 characters
https://review.coreboot.org/#/c/31929/14/get_dgpu_patches.sh File get_dgpu_patches.sh:
https://review.coreboot.org/#/c/31929/14/get_dgpu_patches.sh@4 PS14, Line 4: ### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware line over 80 characters
https://review.coreboot.org/#/c/31929/14/get_dgpu_patches.sh@18 PS14, Line 18: ### src/device/pci: Add support for discrete VGA initialization and OpROM loading line over 80 characters
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31929 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Abandoned
Too many revisions, need a fresh start.
-
build bot (Jenkins) (Code Review) -
Kyösti Mälkki (Code Review)
-
Mike Banon (Code Review)
-
mikeb mikeb (Code Review)