Attention is currently required from: Tarun Tuli, Paul Menzel, Christian Walter, Tim Wawrzynczak, Maximilian Brune, David Milosevic.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68756 )
Change subject: soc/intel/alderlake: Add IBECC
......................................................................
Patch Set 7:
(2 comments)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/68756/comment/d6d5958f_1376c86f
PS7, Line 382: printk(BIOS_DEBUG, "Enable IBECC\n");
I don't think this is meaningful
https://review.coreboot.org/c/coreboot/+/68756/comment/a6e095c0_8c3f4694
PS7, Line 369:
: /* In-Band ECC configuration */
: if (config->ibecc.enable) {
: m_cfg->Ibecc = config->ibecc.enable;
: m_cfg->IbeccOperationMode = config->ibecc.mode;
: if (m_cfg->IbeccOperationMode == IBECC_MODE_PER_REGION) {
: FSP_ARRAY_LOAD(m_cfg->IbeccProtectedRangeEnable,
: config->ibecc.range_enable);
: FSP_ARRAY_LOAD(m_cfg->IbeccProtectedRangeBase,
: config->ibecc.range_base);
: FSP_ARRAY_LOAD(m_cfg->IbeccProtectedRangeMask,
: config->ibecc.range_mask);
: }
: printk(BIOS_DEBUG, "Enable IBECC\n");
: }
please help to create a small helper routine and call into it from line #364
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68756
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9cc2ed6defa1223aa422b9b0d8145f8f8b3dd12e
Gerrit-Change-Number: 68756
Gerrit-PatchSet: 7
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Thu, 03 Nov 2022 08:30:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment