Attention is currently required from: Daniil Lunev, Subrata Banik, Wonkyu Kim, Paul Menzel, Rizwan Qureshi, Angel Pons, Meera Ravindranath, Patrick Rudolph, Gwendal Grignou.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62662 )
Change subject: mb/intel/adlrvp: Enable UFS and ISH for ADL-N RVP
......................................................................
Patch Set 6: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62662/comment/0ecea88c_f4db7f3b
PS6, Line 9: the parent
Actually, `function 0`
suggestion:
```
In order to enable the UFS controller (PCI device 12.7), the PCI specification
says that the device at function 0 in the same slot must also be enabled,
(which is the ISH). Therefore, this CL enables both the UFS controller and ISH.
```
File src/mainboard/intel/adlrvp/devicetree_n.cb:
https://review.coreboot.org/c/coreboot/+/62662/comment/ee9a4c80_3de82882
PS3, Line 283: on
FSP should have migrate this PCI device config space under func 0 using swaping isn't it?
IIUC, the FSP (and the Intel SoCs themselves AFAIK) only support remapping of the PCIe RPs, therefore I believe it is up to the mainboard designer to ensure that their device is PCI compliant w/r/t function 0 being enabled when other functions are also enabled. Right now, the coreboot PCI scanning code will skip scanning functions 1-7 if function 0 is not enabled, unless the multi-function bit is set in the header type (https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If15bcaffc8fd3bbbe4b181820993ab2d882bbbe1
Gerrit-Change-Number: 62662
Gerrit-PatchSet: 6
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniil Lunev
dlunev@chromium.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Gwendal Grignou
gwendal@chromium.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Daniil Lunev
dlunev@chromium.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Gwendal Grignou
gwendal@chromium.org
Gerrit-Comment-Date: Tue, 19 Apr 2022 16:29:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-MessageType: comment