Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29749 )
Change subject: mb/google/dragonegg: Add initial mainboard code support
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/29749/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29749/7//COMMIT_MSG@9
PS7, Line 9: This patch includes support for both ICL ES0 and ES1 samples.
Missing parts:
What was tested ?
What is the test result ?
Are there open TODOs ?
Which BLOBs are necessary to build it ?
How to optain those BLOBs ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29749
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cc269cb0050bf5b031f48cfe114485c55ab8fa9
Gerrit-Change-Number: 29749
Gerrit-PatchSet: 7
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 21 Nov 2018 09:46:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment