Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62890 )
Change subject: soc/mediatek/mt8186: Disable unused spm_thermal ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62890/comment/9c5892c4_c5b69df7 PS3, Line 7: spm_thermal which is not used
unused spm_thermal
Done
https://review.coreboot.org/c/coreboot/+/62890/comment/bd0c1dac_093b758b PS3, Line 9: to influence
from influencing
Done
https://review.coreboot.org/c/coreboot/+/62890/comment/300fc5d7_b9008eb6 PS3, Line 10: For hardware path from thermal to wdt, there is : another path directly from thermal to wdt.
What does this mean? Do we have 2 paths?
I add this in commit message:
There are two hardware pathes which are used for asserting watchdog from thermal. We can disable status of path 1 because status of path 2 is used. 1. Thermal -> SPM -> WDT 2. Thermal -> WDT
https://review.coreboot.org/c/coreboot/+/62890/comment/d311bc66_818d48b6 PS3, Line 13: can
should
Done
-
Rex-BC Chen (Code Review)