Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37565 )
Change subject: mb/razer: Add initial support for the Blade Stealth Mercury White (late 2019)
......................................................................
Patch Set 14: Code-Review+1
(2 comments)
A few small comments
https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade_...
File src/mainboard/razer/blade_stealth_icl/board_info.txt:
https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade_...
PS14, Line 2: Board name: Blade Stealth Ice Lake U Mercury White late 2019 (LY320)
This is not the same as the name in Kconfig.name. Is this difference intended?
https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade_...
File src/mainboard/razer/blade_stealth_icl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade_...
PS14, Line 167: #+-------------------+---------------------------+
The table formatting is broken, here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5711cbcd69813832d9bacc9563f651ab8702554a
Gerrit-Change-Number: 37565
Gerrit-PatchSet: 14
Gerrit-Owner: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christoph Pomaska
github@slrie.de
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Comment-Date: Mon, 10 Feb 2020 21:58:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment