Attention is currently required from: Sean Rhodes, Andy Pont, Paul Menzel, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58343 )
Change subject: ec/starlabs: Add standardised ITE EC support ......................................................................
Patch Set 32:
(4 comments)
File src/ec/starlabs/merlin/ec.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133036): https://review.coreboot.org/c/coreboot/+/58343/comment/fdddc8f2_a74519bd PS32, Line 90: 0)); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133036): https://review.coreboot.org/c/coreboot/+/58343/comment/351416a1_388816c2 PS32, Line 90: 0)); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133036): https://review.coreboot.org/c/coreboot/+/58343/comment/d2675bb8_a42163c3 PS32, Line 210: 2)); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133036): https://review.coreboot.org/c/coreboot/+/58343/comment/eac8b073_555a1fa3 PS32, Line 210: 2)); please, no space before tabs