Change in coreboot[master]: acpi: Add option to stub out Global NVS - coreboot-gerrit

12 Jan 2021


      Attention is currently required from: Martin Roth, Angel Pons.
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49278 )
Change subject: acpi: Add option to stub out Global NVS
......................................................................
Patch Set 1:
(1 comment)
File src/acpi/gnvs.c:
https://review.coreboot.org/c/coreboot/+/49278/comment/7192589c_6f0c6607 
PS1, Line 14: 	if (CONFIG(ACPI_NO_GLOBAL_NVS_SUPPORT))
            : 		return NULL;
Why not totally exclude the gnvs.c file instead of return NULL?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49278
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie31f02c9e279e47ff10562bb077367d4e33f4dd9
Gerrit-Change-Number: 49278
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 12 Jan 2021 14:02:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment