Ana Carolina Cabral has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/84643?usp=email )
Change subject: soc/amd/glinda: Include SPI controller to ACPI ......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84643/comment/f8893cb5_f75b3ac8?usp... : PS5, Line 9: Add
Maybe use *Include*, conveying more that you do not write new code.
Done
https://review.coreboot.org/c/coreboot/+/84643/comment/95f1d518_6bfe043c?usp... : PS5, Line 10:
`Possible unwrapped commit description (prefer a maximum 72 chars per line)` […]
Done
https://review.coreboot.org/c/coreboot/+/84643/comment/2990fd09_ea064ab3?usp... : PS5, Line 11: TEST: On Birman Plus with Glinda SoC, SPI device AMDI0062 is seen in dsdt.dsl table
Please remove the space at the end.
Done