Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39127 )
Change subject: soc/intel/tigerlake: Add function to dump ME firmware status information
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39127/8/src/soc/intel/tigerlake/Mak...
File src/soc/intel/tigerlake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39127/8/src/soc/intel/tigerlake/Mak...
PS8, Line 52: ramstage-y += me.c
You have to do this in the previous patch in the train
https://review.coreboot.org/c/coreboot/+/39127/8/src/soc/intel/tigerlake/me....
File src/soc/intel/tigerlake/me.c:
https://review.coreboot.org/c/coreboot/+/39127/8/src/soc/intel/tigerlake/me....
PS8, Line 144: spi_protection_mode
This bit should be cleared to indicate that SPI protection is in place? in that case the name signifies opposite. spi_protection_dis?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39127
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I831a51f9f482425bd3b97ef1d2404b1d06844d07
Gerrit-Change-Number: 39127
Gerrit-PatchSet: 8
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Poornima Tom
poornima.tom@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Fri, 27 Mar 2020 19:53:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment