Attention is currently required from: Jonathan Zhang, Arthur Heymans, Elyes Haouas.
Shuming Chu (Shuming) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68878 )
Change subject: soc/intel/cmn/block/acpi: enable BERT table without crashlog
......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/common/block/acpi/acpi_bert.c:
https://review.coreboot.org/c/coreboot/+/68878/comment/1598511a_8c0e795c
PS2, Line 9:
: #if (CONFIG(SOC_INTEL_CRASHLOG))
This should not be needed. […]
Done
https://review.coreboot.org/c/coreboot/+/68878/comment/8004973b_aefa54bc
PS2, Line 100: Error:
Please remove. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68878
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I323ca889eef2b246fc4e062582d2d11b4213316f
Gerrit-Change-Number: 68878
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 17 Nov 2022 01:36:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment