HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36372 )
Change subject: src: Remove unused '#include <cpu/cpu.h>' ......................................................................
src: Remove unused '#include <cpu/cpu.h>'
Change-Id: Ibcb1cafe36c255b4c5bd0a4faeedb95e91048709 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/common/fsb.c M src/cpu/via/nano/update_ucode.h M src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c M src/northbridge/intel/gm45/northbridge.c M src/northbridge/intel/nehalem/northbridge.c M src/northbridge/intel/pineview/northbridge.c M src/northbridge/intel/sandybridge/northbridge.c M src/northbridge/intel/x4x/northbridge.c M src/soc/intel/broadwell/lpc.c M src/soc/intel/cannonlake/smmrelocate.c M src/soc/intel/common/block/timer/timer.c M src/soc/intel/icelake/smmrelocate.c M src/soc/nvidia/tegra124/sor.c M src/southbridge/intel/ibexpeak/early_cir.c 14 files changed, 1 insertion(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/36372/1
diff --git a/src/cpu/intel/common/fsb.c b/src/cpu/intel/common/fsb.c index c32bc23..14dbd60 100644 --- a/src/cpu/intel/common/fsb.c +++ b/src/cpu/intel/common/fsb.c @@ -12,7 +12,6 @@ */
#include <arch/early_variables.h> -#include <cpu/cpu.h> #include <cpu/x86/msr.h> #include <cpu/x86/tsc.h> #include <cpu/intel/speedstep.h> diff --git a/src/cpu/via/nano/update_ucode.h b/src/cpu/via/nano/update_ucode.h index 31f5925..7cf3f28 100644 --- a/src/cpu/via/nano/update_ucode.h +++ b/src/cpu/via/nano/update_ucode.h @@ -14,7 +14,7 @@ #ifndef __UPDATE_UCODE_H #define __UPDATE_UCODE_H
-#include <cpu/cpu.h> +#include <stdint.h>
#define MSR_UCODE_UPDATE_STATUS 0x00001205
diff --git a/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c b/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c index 81f5740..7699ebc 100644 --- a/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c +++ b/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c @@ -12,7 +12,6 @@ */
#include <console/console.h> -#include <cpu/cpu.h> #include <cpu/x86/mp.h> #include <cpu/x86/lapic.h> #include <cpu/intel/microcode.h> diff --git a/src/northbridge/intel/gm45/northbridge.c b/src/northbridge/intel/gm45/northbridge.c index 384d98a..e652090 100644 --- a/src/northbridge/intel/gm45/northbridge.c +++ b/src/northbridge/intel/gm45/northbridge.c @@ -20,7 +20,6 @@ #include <device/device.h> #include <device/pci.h> #include <stdlib.h> -#include <cpu/cpu.h> #include <boot/tables.h> #include <arch/acpi.h> #include <cpu/intel/smm_reloc.h> diff --git a/src/northbridge/intel/nehalem/northbridge.c b/src/northbridge/intel/nehalem/northbridge.c index 6ec76e1..0b4920c 100644 --- a/src/northbridge/intel/nehalem/northbridge.c +++ b/src/northbridge/intel/nehalem/northbridge.c @@ -26,7 +26,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <stdlib.h> -#include <cpu/cpu.h> #include "chip.h" #include "nehalem.h" #include <cpu/intel/smm_reloc.h> diff --git a/src/northbridge/intel/pineview/northbridge.c b/src/northbridge/intel/pineview/northbridge.c index 34cb583..fc71bc3 100644 --- a/src/northbridge/intel/pineview/northbridge.c +++ b/src/northbridge/intel/pineview/northbridge.c @@ -21,7 +21,6 @@ #include <device/device.h> #include <device/pci.h> #include <stdlib.h> -#include <cpu/cpu.h> #include <boot/tables.h> #include <arch/acpi.h> #include <northbridge/intel/pineview/pineview.h> diff --git a/src/northbridge/intel/sandybridge/northbridge.c b/src/northbridge/intel/sandybridge/northbridge.c index 58f4a68..6337d69 100644 --- a/src/northbridge/intel/sandybridge/northbridge.c +++ b/src/northbridge/intel/sandybridge/northbridge.c @@ -25,7 +25,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <stdlib.h> -#include <cpu/cpu.h> #include "chip.h" #include "sandybridge.h" #include <cpu/intel/smm_reloc.h> diff --git a/src/northbridge/intel/x4x/northbridge.c b/src/northbridge/intel/x4x/northbridge.c index ee70527..39f24d3 100644 --- a/src/northbridge/intel/x4x/northbridge.c +++ b/src/northbridge/intel/x4x/northbridge.c @@ -21,7 +21,6 @@ #include <device/device.h> #include <device/pci.h> #include <stdlib.h> -#include <cpu/cpu.h> #include <boot/tables.h> #include <arch/acpi.h> #include <northbridge/intel/x4x/iomap.h> diff --git a/src/soc/intel/broadwell/lpc.c b/src/soc/intel/broadwell/lpc.c index 2bebcb8..873f594 100644 --- a/src/soc/intel/broadwell/lpc.c +++ b/src/soc/intel/broadwell/lpc.c @@ -26,7 +26,6 @@ #include <device/pci_ops.h> #include <arch/ioapic.h> #include <arch/acpi.h> -#include <cpu/cpu.h> #include <cpu/x86/smm.h> #include <cbmem.h> #include <reg_script.h> diff --git a/src/soc/intel/cannonlake/smmrelocate.c b/src/soc/intel/cannonlake/smmrelocate.c index 493d003..6680bf3 100644 --- a/src/soc/intel/cannonlake/smmrelocate.c +++ b/src/soc/intel/cannonlake/smmrelocate.c @@ -19,7 +19,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/cpu.h> #include <cpu/x86/cache.h> #include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> diff --git a/src/soc/intel/common/block/timer/timer.c b/src/soc/intel/common/block/timer/timer.c index 70072cc..219c634 100644 --- a/src/soc/intel/common/block/timer/timer.c +++ b/src/soc/intel/common/block/timer/timer.c @@ -14,7 +14,6 @@ */
#include <arch/cpu.h> -#include <cpu/cpu.h> #include <cpu/x86/msr.h> #include <cpu/x86/tsc.h> #include <intelblocks/msr.h> diff --git a/src/soc/intel/icelake/smmrelocate.c b/src/soc/intel/icelake/smmrelocate.c index 65505c4..edcc49d 100644 --- a/src/soc/intel/icelake/smmrelocate.c +++ b/src/soc/intel/icelake/smmrelocate.c @@ -18,7 +18,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/cpu.h> #include <cpu/x86/cache.h> #include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> diff --git a/src/soc/nvidia/tegra124/sor.c b/src/soc/nvidia/tegra124/sor.c index 1c151f5..9554ce9 100644 --- a/src/soc/nvidia/tegra124/sor.c +++ b/src/soc/nvidia/tegra124/sor.c @@ -18,7 +18,6 @@
#include <boot/tables.h> #include <console/console.h> -#include <cpu/cpu.h> #include <delay.h> #include <device/device.h> #include <soc/addressmap.h> diff --git a/src/southbridge/intel/ibexpeak/early_cir.c b/src/southbridge/intel/ibexpeak/early_cir.c index 0048235..8d7a918 100644 --- a/src/southbridge/intel/ibexpeak/early_cir.c +++ b/src/southbridge/intel/ibexpeak/early_cir.c @@ -12,7 +12,6 @@ */
#include <console/console.h> -#include <cpu/cpu.h> #include <device/pci_ops.h> #include <device/pci_def.h> #include <northbridge/intel/nehalem/nehalem.h>
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36372 )
Change subject: src: Remove unused '#include <cpu/cpu.h>' ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36372 )
Change subject: src: Remove unused '#include <cpu/cpu.h>' ......................................................................
src: Remove unused '#include <cpu/cpu.h>'
Change-Id: Ibcb1cafe36c255b4c5bd0a4faeedb95e91048709 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36372 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/cpu/intel/common/fsb.c M src/cpu/via/nano/update_ucode.h M src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c M src/northbridge/intel/gm45/northbridge.c M src/northbridge/intel/nehalem/northbridge.c M src/northbridge/intel/pineview/northbridge.c M src/northbridge/intel/sandybridge/northbridge.c M src/northbridge/intel/x4x/northbridge.c M src/soc/intel/broadwell/lpc.c M src/soc/intel/cannonlake/smmrelocate.c M src/soc/intel/common/block/timer/timer.c M src/soc/intel/icelake/smmrelocate.c M src/soc/nvidia/tegra124/sor.c M src/southbridge/intel/ibexpeak/early_cir.c 14 files changed, 1 insertion(+), 14 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/cpu/intel/common/fsb.c b/src/cpu/intel/common/fsb.c index c32bc23..14dbd60 100644 --- a/src/cpu/intel/common/fsb.c +++ b/src/cpu/intel/common/fsb.c @@ -12,7 +12,6 @@ */
#include <arch/early_variables.h> -#include <cpu/cpu.h> #include <cpu/x86/msr.h> #include <cpu/x86/tsc.h> #include <cpu/intel/speedstep.h> diff --git a/src/cpu/via/nano/update_ucode.h b/src/cpu/via/nano/update_ucode.h index 31f5925..7cf3f28 100644 --- a/src/cpu/via/nano/update_ucode.h +++ b/src/cpu/via/nano/update_ucode.h @@ -14,7 +14,7 @@ #ifndef __UPDATE_UCODE_H #define __UPDATE_UCODE_H
-#include <cpu/cpu.h> +#include <stdint.h>
#define MSR_UCODE_UPDATE_STATUS 0x00001205
diff --git a/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c b/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c index 81f5740..7699ebc 100644 --- a/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c +++ b/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c @@ -12,7 +12,6 @@ */
#include <console/console.h> -#include <cpu/cpu.h> #include <cpu/x86/mp.h> #include <cpu/x86/lapic.h> #include <cpu/intel/microcode.h> diff --git a/src/northbridge/intel/gm45/northbridge.c b/src/northbridge/intel/gm45/northbridge.c index 384d98a..e652090 100644 --- a/src/northbridge/intel/gm45/northbridge.c +++ b/src/northbridge/intel/gm45/northbridge.c @@ -20,7 +20,6 @@ #include <device/device.h> #include <device/pci.h> #include <stdlib.h> -#include <cpu/cpu.h> #include <boot/tables.h> #include <arch/acpi.h> #include <cpu/intel/smm_reloc.h> diff --git a/src/northbridge/intel/nehalem/northbridge.c b/src/northbridge/intel/nehalem/northbridge.c index 39270ed..8f415cb 100644 --- a/src/northbridge/intel/nehalem/northbridge.c +++ b/src/northbridge/intel/nehalem/northbridge.c @@ -26,7 +26,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <stdlib.h> -#include <cpu/cpu.h> #include "chip.h" #include "nehalem.h" #include <cpu/intel/smm_reloc.h> diff --git a/src/northbridge/intel/pineview/northbridge.c b/src/northbridge/intel/pineview/northbridge.c index 34cb583..fc71bc3 100644 --- a/src/northbridge/intel/pineview/northbridge.c +++ b/src/northbridge/intel/pineview/northbridge.c @@ -21,7 +21,6 @@ #include <device/device.h> #include <device/pci.h> #include <stdlib.h> -#include <cpu/cpu.h> #include <boot/tables.h> #include <arch/acpi.h> #include <northbridge/intel/pineview/pineview.h> diff --git a/src/northbridge/intel/sandybridge/northbridge.c b/src/northbridge/intel/sandybridge/northbridge.c index 58f4a68..6337d69 100644 --- a/src/northbridge/intel/sandybridge/northbridge.c +++ b/src/northbridge/intel/sandybridge/northbridge.c @@ -25,7 +25,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <stdlib.h> -#include <cpu/cpu.h> #include "chip.h" #include "sandybridge.h" #include <cpu/intel/smm_reloc.h> diff --git a/src/northbridge/intel/x4x/northbridge.c b/src/northbridge/intel/x4x/northbridge.c index ee70527..39f24d3 100644 --- a/src/northbridge/intel/x4x/northbridge.c +++ b/src/northbridge/intel/x4x/northbridge.c @@ -21,7 +21,6 @@ #include <device/device.h> #include <device/pci.h> #include <stdlib.h> -#include <cpu/cpu.h> #include <boot/tables.h> #include <arch/acpi.h> #include <northbridge/intel/x4x/iomap.h> diff --git a/src/soc/intel/broadwell/lpc.c b/src/soc/intel/broadwell/lpc.c index 2bebcb8..873f594 100644 --- a/src/soc/intel/broadwell/lpc.c +++ b/src/soc/intel/broadwell/lpc.c @@ -26,7 +26,6 @@ #include <device/pci_ops.h> #include <arch/ioapic.h> #include <arch/acpi.h> -#include <cpu/cpu.h> #include <cpu/x86/smm.h> #include <cbmem.h> #include <reg_script.h> diff --git a/src/soc/intel/cannonlake/smmrelocate.c b/src/soc/intel/cannonlake/smmrelocate.c index 493d003..6680bf3 100644 --- a/src/soc/intel/cannonlake/smmrelocate.c +++ b/src/soc/intel/cannonlake/smmrelocate.c @@ -19,7 +19,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/cpu.h> #include <cpu/x86/cache.h> #include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> diff --git a/src/soc/intel/common/block/timer/timer.c b/src/soc/intel/common/block/timer/timer.c index 70072cc..219c634 100644 --- a/src/soc/intel/common/block/timer/timer.c +++ b/src/soc/intel/common/block/timer/timer.c @@ -14,7 +14,6 @@ */
#include <arch/cpu.h> -#include <cpu/cpu.h> #include <cpu/x86/msr.h> #include <cpu/x86/tsc.h> #include <intelblocks/msr.h> diff --git a/src/soc/intel/icelake/smmrelocate.c b/src/soc/intel/icelake/smmrelocate.c index 65505c4..edcc49d 100644 --- a/src/soc/intel/icelake/smmrelocate.c +++ b/src/soc/intel/icelake/smmrelocate.c @@ -18,7 +18,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/cpu.h> #include <cpu/x86/cache.h> #include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> diff --git a/src/soc/nvidia/tegra124/sor.c b/src/soc/nvidia/tegra124/sor.c index 1c151f5..9554ce9 100644 --- a/src/soc/nvidia/tegra124/sor.c +++ b/src/soc/nvidia/tegra124/sor.c @@ -18,7 +18,6 @@
#include <boot/tables.h> #include <console/console.h> -#include <cpu/cpu.h> #include <delay.h> #include <device/device.h> #include <soc/addressmap.h> diff --git a/src/southbridge/intel/ibexpeak/early_cir.c b/src/southbridge/intel/ibexpeak/early_cir.c index 0048235..8d7a918 100644 --- a/src/southbridge/intel/ibexpeak/early_cir.c +++ b/src/southbridge/intel/ibexpeak/early_cir.c @@ -12,7 +12,6 @@ */
#include <console/console.h> -#include <cpu/cpu.h> #include <device/pci_ops.h> #include <device/pci_def.h> #include <northbridge/intel/nehalem/nehalem.h>
-
HAOUAS Elyes (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)