HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33331
Change subject: arch/x86/rdrand.c: Remove unneeded 'else' ......................................................................
arch/x86/rdrand.c: Remove unneeded 'else'
'else' is not needed after a 'break' or 'return'.
Change-Id: Ib7bdefb0027a35de42f6a665b98f9e5a2791061f Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/rdrand.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/33331/1
diff --git a/src/arch/x86/rdrand.c b/src/arch/x86/rdrand.c index 35aac71..c9090df 100644 --- a/src/arch/x86/rdrand.c +++ b/src/arch/x86/rdrand.c @@ -75,7 +75,6 @@ #if ENV_X86_64 if (rdrand_64(rand)) return 0; - else #endif if (rdrand_32(&rand_high) && rdrand_32(&rand_low)) { *rand = ((uint64_t)rand_high << 32) |
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33331 )
Change subject: arch/x86/rdrand.c: Remove unneeded 'else' ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33331 )
Change subject: arch/x86/rdrand.c: Remove unneeded 'else' ......................................................................
arch/x86/rdrand.c: Remove unneeded 'else'
'else' is not needed after a 'break' or 'return'.
Change-Id: Ib7bdefb0027a35de42f6a665b98f9e5a2791061f Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33331 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Vlado Cibic Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/arch/x86/rdrand.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Vlado Cibic: Looks good to me, but someone else must approve
diff --git a/src/arch/x86/rdrand.c b/src/arch/x86/rdrand.c index 35aac71..c9090df 100644 --- a/src/arch/x86/rdrand.c +++ b/src/arch/x86/rdrand.c @@ -75,7 +75,6 @@ #if ENV_X86_64 if (rdrand_64(rand)) return 0; - else #endif if (rdrand_32(&rand_high) && rdrand_32(&rand_low)) { *rand = ((uint64_t)rand_high << 32) |