Change in coreboot[master]: device/pnp,util/sconfig: introduce and use `REG8` resource type - coreboot-gerrit

27 Dec 2020


      Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48925 )
Change subject: device/pnp,util/sconfig: introduce and use `REG8` resource type
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48925/3//COMMIT_MSG 
Commit Message:
https://review.coreboot.org/c/coreboot/+/48925/3//COMMIT_MSG@12 
PS3, Line 12: 0x[3f]
...
Why I suggested 0x[^7]: the whole pattern should be safe. /[di]rq 0x[^7]/ […]
sorry, you're right. 0x8 is drq, isn't it?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/48925
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36679148cbfdbd1e38b3c4ce092562769f9806ab
Gerrit-Change-Number: 48925
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 27 Dec 2020 18:02:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment