Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59666 )
Change subject: soc/intel/alderlake: Implement function to map physical port to EC port ......................................................................
Patch Set 2:
(5 comments)
File src/soc/intel/alderlake/retimer.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134328): https://review.coreboot.org/c/coreboot/+/59666/comment/d6180e1f_1ec070a7 PS2, Line 20: for (uint8_t i = 0; i < MAX_TYPE_C_PORTS; i++) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134328): https://review.coreboot.org/c/coreboot/+/59666/comment/615eae76_7c5eb7ce PS2, Line 28: ec_port++; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134328): https://review.coreboot.org/c/coreboot/+/59666/comment/e31f8e4d_2334aeee PS2, Line 28: ec_port++; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134328): https://review.coreboot.org/c/coreboot/+/59666/comment/53afff05_0ac04184 PS2, Line 28: ec_port++; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134328): https://review.coreboot.org/c/coreboot/+/59666/comment/820cc63c_0c2af1ea PS2, Line 32: die("Couldn't find correct port mapping or Invalid input port \n"); unnecessary whitespace before a quoted newline