Attention is currently required from: Furquan Shaikh, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52588 )
Change subject: soc/intel/common: Add virtual wire mapping entries to GPIO communities ......................................................................
Patch Set 5:
(4 comments)
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/52588/comment/15cffdbe_4b1be8ee PS4, Line 784: comm->vw_entries[i].first_pad
Shouldn't this be `pad - comm->vw_entries[i]. […]
Done
File src/soc/intel/common/block/include/intelblocks/gpio.h:
https://review.coreboot.org/c/coreboot/+/52588/comment/377c1cc6_ab7b93c5 PS4, Line 133:
nit: use tab like other members?
The other struct entries don't have one between `struct` and the rest of the type, but they do after the full type name, I can add it there.
https://review.coreboot.org/c/coreboot/+/52588/comment/ffe46595_b6489276 PS4, Line 133: vw_entries
Should we add a comment here that the entries are supposed to be in the order in which the groups ma […]
Done
https://review.coreboot.org/c/coreboot/+/52588/comment/8fdda651_ff0b0cbf PS4, Line 252: it will return 1, and vw_index and vw_bit will be set to -1
Needs update.
Done