Attention is currently required from: Furquan Shaikh, Patrick Rudolph.
4 comments:
File src/soc/intel/common/block/gpio/gpio.c:
Patch Set #4, Line 784: comm->vw_entries[i].first_pad
Shouldn't this be `pad - comm->vw_entries[i]. […]
Done
File src/soc/intel/common/block/include/intelblocks/gpio.h:
nit: use tab like other members?
The other struct entries don't have one between `struct` and the rest of the type, but they do after the full type name, I can add it there.
Patch Set #4, Line 133: vw_entries
Should we add a comment here that the entries are supposed to be in the order in which the groups ma […]
Done
Patch Set #4, Line 252: it will return 1, and vw_index and vw_bit will be set to -1
Needs update.
Done
To view, visit change 52588. To unsubscribe, or for help writing mail filters, visit settings.