Change in ...coreboot[master]: src/lib: Use 'include <stdlib.h>' when appropriate

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33692

Change subject: src/lib: Use 'include <stdlib.h>' when appropriate
......................................................................

src/lib: Use 'include <stdlib.h>' when appropriate

Change-Id: I364bbb31e95958df2ac8188ba5618f4f1c3427a4
Signed-off-by: Elyes HAOUAS 
---
M src/lib/bootmem.c
M src/lib/cbfs.c
M src/lib/fit.c
M src/lib/fit_payload.c
M src/lib/imd.c
M src/lib/imd_cbmem.c
M src/lib/prog_loaders.c
M src/lib/rmodule.c
M src/lib/selfboot.c
9 files changed, 10 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/33692/1

diff --git a/src/lib/bootmem.c b/src/lib/bootmem.c
index 01ad3e8..61253cf 100644
--- a/src/lib/bootmem.c
+++ b/src/lib/bootmem.c
@@ -19,7 +19,7 @@
 #include <bootmem.h>
 #include <cbmem.h>
 #include <device/resource.h>
-#include <stdlib.h>
+#include <stddef.h>
 #include <symbols.h>
 #include <assert.h>

diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c
index 91368fb..001d80f 100644
--- a/src/lib/cbfs.c
+++ b/src/lib/cbfs.c
@@ -17,12 +17,13 @@
 #include <assert.h>
 #include <console/console.h>
 #include <string.h>
-#include <stdlib.h>
 #include <boot_device.h>
 #include <cbfs.h>
 #include <commonlib/compression.h>
 #include <endian.h>
 #include <lib.h>
+#include <stddef.h>
+#include <stdint.h>
 #include <symbols.h>
 #include <timestamp.h>
 #include <fmap.h>
diff --git a/src/lib/fit.c b/src/lib/fit.c
index 045f52f..77bd766 100644
--- a/src/lib/fit.c
+++ b/src/lib/fit.c
@@ -20,7 +20,7 @@
 #include <endian.h>
 #include <stdint.h>
 #include <bootmem.h>
-#include <stdlib.h>
+#include <stddef.h>
 #include <string.h>
 #include <program_loading.h>
 #include <memrange.h>
diff --git a/src/lib/fit_payload.c b/src/lib/fit_payload.c
index 8e75915..1cf5ed8 100644
--- a/src/lib/fit_payload.c
+++ b/src/lib/fit_payload.c
@@ -19,10 +19,10 @@
 #include <bootmem.h>
 #include <cbmem.h>
 #include <device/resource.h>
-#include <stdlib.h>
 #include <commonlib/region.h>
 #include <fit.h>
 #include <program_loading.h>
+#include <stddef.h>
 #include <timestamp.h>
 #include <string.h>
 #include <commonlib/cbfs_serialized.h>
diff --git a/src/lib/imd.c b/src/lib/imd.c
index 17ec2d9..de91f2a 100644
--- a/src/lib/imd.c
+++ b/src/lib/imd.c
@@ -17,7 +17,7 @@
 #include <cbmem.h>
 #include <console/console.h>
 #include <imd.h>
-#include <stdlib.h>
+#include <stddef.h>
 #include <string.h>

/* For more details on implementation and usage please see the imd.h header. */
diff --git a/src/lib/imd_cbmem.c b/src/lib/imd_cbmem.c
index 1a67ad5..6ec2150 100644
--- a/src/lib/imd_cbmem.c
+++ b/src/lib/imd_cbmem.c
@@ -19,8 +19,8 @@
 #include <cbmem.h>
 #include <imd.h>
 #include <lib.h>
-#include <stdlib.h>
 #include <arch/early_variables.h>
+#include <stddef.h>

/*
  * We need special handling on x86 where CAR global migration is employed. One
diff --git a/src/lib/prog_loaders.c b/src/lib/prog_loaders.c
index 81ec2ec..b39d016 100644
--- a/src/lib/prog_loaders.c
+++ b/src/lib/prog_loaders.c
@@ -14,7 +14,6 @@
  */

-#include <stdlib.h>
 #include <cbfs.h>
 #include <cbmem.h>
 #include <console/console.h>
@@ -26,6 +25,7 @@
 #include <romstage_handoff.h>
 #include <rmodule.h>
 #include <stage_cache.h>
+#include <stddef.h>
 #include <symbols.h>
 #include <timestamp.h>
 #include <fit_payload.h>
diff --git a/src/lib/rmodule.c b/src/lib/rmodule.c
index 56529d2..a34bac7 100644
--- a/src/lib/rmodule.c
+++ b/src/lib/rmodule.c
@@ -15,8 +15,8 @@
 #include <assert.h>
 #include <cbmem.h>
 #include <cbfs.h>
+#include <stddef.h>
 #include <stdint.h>
-#include <stdlib.h>
 #include <string.h>
 #include <console/console.h>
 #include <program_loading.h>
diff --git a/src/lib/selfboot.c b/src/lib/selfboot.c
index a0bb711..2d64634 100644
--- a/src/lib/selfboot.c
+++ b/src/lib/selfboot.c
@@ -18,8 +18,8 @@
 #include <commonlib/compression.h>
 #include <commonlib/endian.h>
 #include <console/console.h>
+#include <stddef.h>
 #include <stdint.h>
-#include <stdlib.h>
 #include <string.h>
 #include <symbols.h>
 #include <cbfs.h>

Change in coreboot[master]: src/lib: Use 'include <stdlib.h>' when appropriate

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33692

to look at the new patch set (#4).

Change subject: src/lib: Use 'include <stdlib.h>' when appropriate
......................................................................

src/lib: Use 'include <stdlib.h>' when appropriate

Also including <types.h>, is supposed to provide stdint and stddef.

Change-Id: I364bbb31e95958df2ac8188ba5618f4f1c3427a4
Signed-off-by: Elyes HAOUAS 
---
M src/lib/bootmem.c
M src/lib/cbfs.c
M src/lib/fit.c
M src/lib/fit_payload.c
M src/lib/imd.c
M src/lib/imd_cbmem.c
M src/lib/prog_loaders.c
M src/lib/rmodule.c
M src/lib/selfboot.c
9 files changed, 9 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/33692/4

Change in coreboot[master]: src/lib: Use 'include <stdlib.h>' when appropriate

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33692 )

Change subject: src/lib: Use 'include <stdlib.h>' when appropriate
......................................................................

Abandoned

see 32023