[XS] Change in coreboot[main]: soc/mediatek/mt8196: Add delay in pmif_spmi.c

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85799?usp=email )

Change subject: soc/mediatek/mt8196: Add delay in pmif_spmi.c
......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85799/comment/53b0a8eb_f698037c?usp... :
PS2, Line 7: Add delay in pmif_spmi.c
Can we be more specific? For example, `Delay 0.5ms before enabling cmd issue`.

Also, does the delay need to be put between `pmif_spmi_enable_swinf` and `pmif_spmi_enable_cmd_issue`? If I read the code correctly, the calibration happens within `spmi_mst_init`. I wonder if we can put the delay at the end of the `if (arb->is_pmif_init_done(arb) != 0)` clause in `pmif_spmi_init()`.