Attention is currently required from: Jeff Daly, Jonathan Zhang, Angel Pons, Arthur Heymans, Kyösti Mälkki, Tarun Tuli, Sean Rhodes, Subrata Banik, Johnny Lin, Kapil Porwal, Christian Walter, Vanessa Eusebio, Lean Sheng Tan, Werner Zeh, Tim Chu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69760 )
Change subject: [NOTFORMERGE] squashed intel pmutil ops
......................................................................
Patch Set 5:
(4 comments)
File src/soc/intel/baytrail/pmutil.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164197):
https://review.coreboot.org/c/coreboot/+/69760/comment/f5d5e9e8_c4533e30
PS5, Line 314: #if 0
Consider removing the code enclosed by this #if 0 and its #endif
File src/soc/intel/braswell/pmutil.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164197):
https://review.coreboot.org/c/coreboot/+/69760/comment/374dfada_9b5b0b87
PS5, Line 314: #if 0
Consider removing the code enclosed by this #if 0 and its #endif
File src/soc/intel/broadwell/pch/pmutil.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164197):
https://review.coreboot.org/c/coreboot/+/69760/comment/315fe42f_9640dcf4
PS5, Line 398: #if 0
Consider removing the code enclosed by this #if 0 and its #endif
File src/southbridge/intel/common/pmbase.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164197):
https://review.coreboot.org/c/coreboot/+/69760/comment/0c16ddf4_c7e61083
PS5, Line 18: !CONFIG(SOC_INTEL_BRASWELL)
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69760
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b4db32888a6a979eee0cbcdbace97bc188ae71b
Gerrit-Change-Number: 69760
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 21 Nov 2022 17:42:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment