Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46543 )
Change subject: soc/intel/common: Fix ACPI device name for USB4 DMA device ......................................................................
soc/intel/common: Fix ACPI device name for USB4 DMA device
The USB4 host interface (DMA) devices need to use SA_DEVFN_* instead of SA_DEV_* when determining the ACPI name.
The matching names are removed from the SOC-level ACPI name handler since they are provided by this driver now.
TEST=boot on volteer and ensure TDM0 device is in the SSDT.
Signed-off-by: Duncan Laurie dlaurie@google.com Change-Id: If778bda82b80593452a590962dbffef6eff6484a --- M src/soc/intel/common/block/usb4/usb4.c M src/soc/intel/tigerlake/chip.c 2 files changed, 2 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/46543/1
diff --git a/src/soc/intel/common/block/usb4/usb4.c b/src/soc/intel/common/block/usb4/usb4.c index 7c545f6..df2dfdd 100644 --- a/src/soc/intel/common/block/usb4/usb4.c +++ b/src/soc/intel/common/block/usb4/usb4.c @@ -15,9 +15,9 @@ static const char *tbt_dma_acpi_name(const struct device *dev) { switch (dev->path.pci.devfn) { - case SA_DEV_TCSS_DMA0: + case SA_DEVFN_TCSS_DMA0: return "TDM0"; - case SA_DEV_TCSS_DMA1: + case SA_DEVFN_TCSS_DMA1: return "TDM1"; default: return NULL; diff --git a/src/soc/intel/tigerlake/chip.c b/src/soc/intel/tigerlake/chip.c index 98ed55c..46c043f 100644 --- a/src/soc/intel/tigerlake/chip.c +++ b/src/soc/intel/tigerlake/chip.c @@ -68,8 +68,6 @@ case SA_DEVFN_ROOT: return "MCHC"; case SA_DEVFN_TCSS_XHCI: return "TXHC"; case SA_DEVFN_TCSS_XDCI: return "TXDC"; - case SA_DEVFN_TCSS_DMA0: return "TDM0"; - case SA_DEVFN_TCSS_DMA1: return "TDM1"; case SA_DEVFN_TBT0: return "TRP0"; case SA_DEVFN_TBT1: return "TRP1"; case SA_DEVFN_TBT2: return "TRP2";
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46543 )
Change subject: soc/intel/common: Fix ACPI device name for USB4 DMA device ......................................................................
Patch Set 1: Code-Review+2
Duncan Laurie has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46543 )
Change subject: soc/intel/common: Fix ACPI device name for USB4 DMA device ......................................................................
soc/intel/common: Fix ACPI device name for USB4 DMA device
The USB4 host interface (DMA) devices need to use SA_DEVFN_* instead of SA_DEV_* when determining the ACPI name.
The matching names are removed from the SOC-level ACPI name handler since they are provided by this driver now.
TEST=boot on volteer and ensure TDM0 device is in the SSDT.
Signed-off-by: Duncan Laurie dlaurie@google.com Change-Id: If778bda82b80593452a590962dbffef6eff6484a Reviewed-on: https://review.coreboot.org/c/coreboot/+/46543 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/common/block/usb4/usb4.c M src/soc/intel/tigerlake/chip.c 2 files changed, 2 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/intel/common/block/usb4/usb4.c b/src/soc/intel/common/block/usb4/usb4.c index 7c545f6..df2dfdd 100644 --- a/src/soc/intel/common/block/usb4/usb4.c +++ b/src/soc/intel/common/block/usb4/usb4.c @@ -15,9 +15,9 @@ static const char *tbt_dma_acpi_name(const struct device *dev) { switch (dev->path.pci.devfn) { - case SA_DEV_TCSS_DMA0: + case SA_DEVFN_TCSS_DMA0: return "TDM0"; - case SA_DEV_TCSS_DMA1: + case SA_DEVFN_TCSS_DMA1: return "TDM1"; default: return NULL; diff --git a/src/soc/intel/tigerlake/chip.c b/src/soc/intel/tigerlake/chip.c index 98ed55c..46c043f 100644 --- a/src/soc/intel/tigerlake/chip.c +++ b/src/soc/intel/tigerlake/chip.c @@ -68,8 +68,6 @@ case SA_DEVFN_ROOT: return "MCHC"; case SA_DEVFN_TCSS_XHCI: return "TXHC"; case SA_DEVFN_TCSS_XDCI: return "TXDC"; - case SA_DEVFN_TCSS_DMA0: return "TDM0"; - case SA_DEVFN_TCSS_DMA1: return "TDM1"; case SA_DEVFN_TBT0: return "TRP0"; case SA_DEVFN_TBT1: return "TRP1"; case SA_DEVFN_TBT2: return "TRP2";
-
Duncan Laurie (Code Review) -
Furquan Shaikh (Code Review)