Change in ...coreboot[master]: crossgcc: Upgrade GCC to 9.1.0

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

3 May 2019 3 May '19

11:03 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32564

Change subject: crossgcc: Upgrade GCC to 9.1.0 ......................................................................

crossgcc: Upgrade GCC to 9.1.0

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.1.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.1.0_gnat.patch R util/crossgcc/patches/gcc-9.1.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.1.0.tar.xz.cksum 7 files changed, 2 insertions(+), 21,021 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/1

Attachments:

attachment.htm (text/html — 1.9 KB)

Show replies by date

HAOUAS Elyes (Code Review)

3 May 3 May

11:05 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.1.0 ......................................................................

Patch Set 1:

seems that all warnings are being treated as errors

HAOUAS Elyes (Code Review)

8 May 8 May

6:28 p.m.

New subject: Change in ...coreboot[master]: [Test] crossgcc: Upgrade GCC to 9.1.0

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#2).

Change subject: [Test] crossgcc: Upgrade GCC to 9.1.0 ......................................................................

[Test] crossgcc: Upgrade GCC to 9.1.0

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/Kconfig M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.1.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.1.0_gnat.patch R util/crossgcc/patches/gcc-9.1.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.1.0.tar.xz.cksum 8 files changed, 3 insertions(+), 21,022 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/2

HAOUAS Elyes (Code Review)

12 May 12 May

8:27 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#3).

Change subject: crossgcc: Upgrade GCC to 9.1.0 ......................................................................

crossgcc: Upgrade GCC to 9.1.0

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/3

HAOUAS Elyes (Code Review)

24 May 24 May

9:38 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#4).

Change subject: crossgcc: Upgrade GCC to 9.1.0 ......................................................................

crossgcc: Upgrade GCC to 9.1.0

GCC added and enable by default -Waddress-of-packed-member. This will fail to build as all warnings are being treated as errors.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.1.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.1.0_gnat.patch R util/crossgcc/patches/gcc-9.1.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.1.0.tar.xz.cksum 8 files changed, 3 insertions(+), 21,022 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/4

HAOUAS Elyes (Code Review)

28 May 28 May

4:58 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#5).

Change subject: crossgcc: Upgrade GCC to 9.1.0 ......................................................................

crossgcc: Upgrade GCC to 9.1.0

GCC added and enable by default -Waddress-of-packed-member. This will fail to build as all warnings are being treated as errors.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/5

HAOUAS Elyes (Code Review)

10 Jun 10 Jun

11:46 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#7).

Change subject: crossgcc: Upgrade GCC to 9.1.0 ......................................................................

crossgcc: Upgrade GCC to 9.1.0

GCC added and enable by default -Waddress-of-packed-member. This will fail to build as all warnings are being treated as errors.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/7

HAOUAS Elyes (Code Review)

1:58 p.m.

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.1.0 ......................................................................

Abandoned

HAOUAS Elyes (Code Review)

11 Jun 11 Jun

6:51 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.1.0 ......................................................................

Patch Set 7:

New Wddress-of-packed-member warning option is enabled by default, but -Wno-error=address-of-packed-member option is not known by the builder.

HAOUAS Elyes (Code Review)

16 Aug 16 Aug

11:35 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.1.0

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.1.0 ......................................................................

Restored

HAOUAS Elyes (Code Review)

11:35 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#8).

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

crossgcc: Upgrade GCC to 9.2.0

GCC added and enable by default -Waddress-of-packed-member. This will fail to build as all warnings are being treated as errors.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.2.0_gnat.patch R util/crossgcc/patches/gcc-9.2.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum 9 files changed, 3 insertions(+), 21,171 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/8

Jacob Garber (Code Review)

17 Aug 17 Aug

12:59 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 8:

You may want to rebase this on CB:34918, where I've tried to fix some of the build errors.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 16 Aug 2019 22:59:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

18 Aug 18 Aug

12:04 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#10).

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

crossgcc: Upgrade GCC to 9.2.0

GCC added and enable by default -Waddress-of-packed-member. This will fail to build as all warnings are being treated as errors.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.2.0_gnat.patch R util/crossgcc/patches/gcc-9.2.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum 9 files changed, 3 insertions(+), 21,171 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/10

Jacob Garber (Code Review)

19 Aug 19 Aug

4:13 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 10:

We'll also need to add -Wno-address-of-packed-member to libpayload and chromium EC. There is also a problem with the -Wstack-usage on Cavium platforms, though I'm not sure how to fix that.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 10 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 19 Aug 2019 14:13:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jacob Garber (Code Review)

25 Sep 25 Sep

6:29 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 10:

To fix the rest of the build errors, I think setting

GCC_CFLAGS_${TARCH}+=-Wlogical-op -Wno-address-of-packed-member

in util/xcompile/xcompile will ignore this warning for all projects, including Chromium EC and libpayload.

Also, the STACK_SIZE value in soc/cavium/cn81xx/Kconfig needs to be changed from hex to decimal, since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 10 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 25 Sep 2019 04:29:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

8:26 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 10:

...

Patch Set 10:

To fix the rest of the build errors, I think setting
GCC_CFLAGS_${TARCH}+=-Wlogical-op -Wno-address-of-packed-member
in util/xcompile/xcompile will ignore this warning for all projects, including Chromium EC and libpayload.

Also, the STACK_SIZE value in soc/cavium/cn81xx/Kconfig needs to be changed from hex to decimal, since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

Thx lint will not accept non hex value: "check Kconfig files for errors (lint-stable-008-kconfig): #!!!!! Error: non hex default value (8192) used for hex symbol STACK_SIZE at src/soc/cavium/cn81xx/Kconfig:33. # 1 errors test failed"

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 10 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 25 Sep 2019 06:26:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

8:33 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#11).

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

crossgcc: Upgrade GCC to 9.2.0

GCC added and enable by default -Waddress-of-packed-member. This will fail to build as all warnings are being treated as errors.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc M src/soc/cavium/cn81xx/Kconfig M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.2.0_gnat.patch R util/crossgcc/patches/gcc-9.2.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum M util/xcompile/xcompile 11 files changed, 5 insertions(+), 21,173 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/11

HAOUAS Elyes (Code Review)

8:42 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#12).

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

crossgcc: Upgrade GCC to 9.2.0

GCC added and enable by default -Waddress-of-packed-member. This will fail to build as all warnings are being treated as errors.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.2.0_gnat.patch R util/crossgcc/patches/gcc-9.2.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum M util/xcompile/xcompile 10 files changed, 4 insertions(+), 21,172 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/12

Patrick Georgi (Code Review)

3 Oct 3 Oct

6:41 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 17:

(1 comment)

Please add a comment about what's going on with nds32 to the commit message: is the patch integrated in upstream and so we don't need it anymore? is it abandoned?

https://review.coreboot.org/c/coreboot/+/32564/17/Makefile.inc File Makefile.inc:

https://review.coreboot.org/c/coreboot/+/32564/17/Makefile.inc@408 PS17, Line 408: CFLAGS_common += -Wno-address-of-packed-member so we have this here and in xcompile?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 17 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 03 Oct 2019 16:41:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:27 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#18).

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

crossgcc: Upgrade GCC to 9.2.0

GCC added and enable by default -Waddress-of-packed-member. This will fail to build as all warnings are being treated as errors.

Now, nds32 patch is integrated in upstream so we don't need it anymore.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.2.0_gnat.patch R util/crossgcc/patches/gcc-9.2.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum M util/xcompile/xcompile 10 files changed, 4 insertions(+), 21,172 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/18

HAOUAS Elyes (Code Review)

7:27 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#19).

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

crossgcc: Upgrade GCC to 9.2.0

GCC added and enable by default -Waddress-of-packed-member. This will fail to build as all warnings are being treated as errors.

Now, nds32 patch is integrated in upstream so we don't need it anymore.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.2.0_gnat.patch R util/crossgcc/patches/gcc-9.2.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum M util/xcompile/xcompile 9 files changed, 3 insertions(+), 21,172 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/19

HAOUAS Elyes (Code Review)

7:28 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 19:

(1 comment)

Thx

https://review.coreboot.org/c/coreboot/+/32564/17/Makefile.inc File Makefile.inc:

https://review.coreboot.org/c/coreboot/+/32564/17/Makefile.inc@408 PS17, Line 408: CFLAGS_common += -Wno-address-of-packed-member

...

so we have this here and in xcompile?

oops, you are right. it is not needed anymore here

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 19 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 03 Oct 2019 17:28:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Jacob Garber (Code Review)

4 Oct 4 Oct

1:22 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 19:

Was the GNAT bad constant patch also merged upstream?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 19 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 03 Oct 2019 23:22:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

8:45 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#20).

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

crossgcc: Upgrade GCC to 9.2.0

GCC added and enable by default -Waddress-of-packed-member. This will fail to build as all warnings are being treated as errors.

Now, nds32 and GNAT bad constant patchs are integrated in upstream so we don't need them anymore.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.2.0_gnat.patch R util/crossgcc/patches/gcc-9.2.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum M util/xcompile/xcompile 9 files changed, 3 insertions(+), 21,172 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/20

HAOUAS Elyes (Code Review)

8:50 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 20:

...

Patch Set 19:

Was the GNAT bad constant patch also merged upstream?

that patch were added recently, it is already integrated in 9.x.x series.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 20 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 04 Oct 2019 06:50:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

8:51 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 20:

...

Patch Set 20:

...
Patch Set 19:

Was the GNAT bad constant patch also merged upstream?

that patch was* added recently, it is already integrated in 9.x.x series.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 20 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 04 Oct 2019 06:51:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jacob Garber (Code Review)

6:32 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 20:

(2 comments)

https://review.coreboot.org/c/coreboot/+/32564/20//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/32564/20//COMMIT_MSG@10 PS20, Line 10: This will fail to build as all warnings are being treated as errors. Maybe add that the solution was to ignore it in xcompile.

https://review.coreboot.org/c/coreboot/+/32564/20//COMMIT_MSG@12 PS20, Line 12: patchs patches

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 20 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 04 Oct 2019 16:32:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

6:54 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#21).

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

crossgcc: Upgrade GCC to 9.2.0

GCC added and enable by default -Waddress-of-packed-member. This will fail to build as all warnings are being treated as errors. To solve this, the solution was to ignore -Waddress-of-packed-member in xcompile.

Also, nds32 and GNAT bad constant patches are integrated in upstream so we don't need them anymore.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.2.0_gnat.patch R util/crossgcc/patches/gcc-9.2.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum M util/xcompile/xcompile 9 files changed, 3 insertions(+), 21,172 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/21

HAOUAS Elyes (Code Review)

7:03 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 21:

(2 comments)

Thank you

https://review.coreboot.org/c/coreboot/+/32564/20//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/32564/20//COMMIT_MSG@10 PS20, Line 10: This will fail to build as all warnings are being treated as errors.

...

Maybe add that the solution was to ignore it in xcompile.

Ack

https://review.coreboot.org/c/coreboot/+/32564/20//COMMIT_MSG@12 PS20, Line 12: patchs

...

patches

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 21 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 04 Oct 2019 17:03:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jacob Garber jgarber1@ualberta.ca Gerrit-MessageType: comment

Jacob Garber (Code Review)

9:14 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 21: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/32564/17/Makefile.inc File Makefile.inc:

https://review.coreboot.org/c/coreboot/+/32564/17/Makefile.inc@408 PS17, Line 408: CFLAGS_common += -Wno-address-of-packed-member

...

oops, you are right. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 21 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 04 Oct 2019 19:14:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Jett Rink (Code Review)

25 Oct 25 Oct

10:06 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 21:

Do we not need a nds32_ite patch for 9.2.0?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 21 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Fri, 25 Oct 2019 20:06:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10:12 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 21:

...

Patch Set 21:

Do we not need a nds32_ite patch for 9.2.0?

nds32_ite and GNAT bad constant patches are integrated in upstream

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 21 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Fri, 25 Oct 2019 20:12:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jett Rink (Code Review)

11:31 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 21: Code-Review+1

...

Patch Set 21:

...
Patch Set 21:

Do we not need a nds32_ite patch for 9.2.0?

nds32_ite and GNAT bad constant patches are integrated in upstream

Ah yes, I see that in the comment header now. Thanks!

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 21 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Fri, 25 Oct 2019 21:31:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

19 Nov 19 Nov

12:25 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 21:

(1 comment)

https://review.coreboot.org/c/coreboot/+/32564/21/util/xcompile/xcompile File util/xcompile/xcompile:

https://review.coreboot.org/c/coreboot/+/32564/21/util/xcompile/xcompile@230 PS21, Line 230: GCC_CFLAGS_${TARCH}+=-Wlogical-op -Wno-address-of-packed-member Could you split this out into a separate commit that could go in before the coreboot 4.11 release?

...

Explicitly disable warning no-address-of-packed-member

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 21 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Mon, 18 Nov 2019 23:25:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:02 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 21:

(1 comment)

https://review.coreboot.org/c/coreboot/+/32564/21/util/xcompile/xcompile File util/xcompile/xcompile:

https://review.coreboot.org/c/coreboot/+/32564/21/util/xcompile/xcompile@230 PS21, Line 230: GCC_CFLAGS_${TARCH}+=-Wlogical-op -Wno-address-of-packed-member

...

Could you split this out into a separate commit that could go in before the coreboot 4.11 release? […]

Yes for sure. Thx

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 21 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Tue, 19 Nov 2019 03:02:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

8:12 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Hello Jacob Garber, Jett Rink, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#22).

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

crossgcc: Upgrade GCC to 9.2.0

nds32 and GNAT bad constant patches are integrated in upstream so we don't need them anymore.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_ada-musl_workaround.patch D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_gnat.patch D util/crossgcc/patches/gcc-8.3.0_libgcc.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum 7 files changed, 1 insertion(+), 21,362 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/22

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 22 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

8:53 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Hello Jacob Garber, Jett Rink, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#23).

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

crossgcc: Upgrade GCC to 9.2.0

nds32 and GNAT bad constant patches are integrated in upstream so we don't need them anymore.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.2.0_gnat.patch R util/crossgcc/patches/gcc-9.2.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum 8 files changed, 2 insertions(+), 21,171 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/23

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 23 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

22 Nov 22 Nov

6 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 26: Code-Review-1

1- not rebased on master

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 26 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Fri, 22 Nov 2019 17:00:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:49 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

HAOUAS Elyes has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Removed Code-Review-1 by HAOUAS Elyes ehaouas@noos.fr

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 27 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-MessageType: deleteVote

HAOUAS Elyes (Code Review)

8 Dec 8 Dec

1:45 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Hello Jacob Garber, Jett Rink, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#28).

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

crossgcc: Upgrade GCC to 9.2.0

nds32 and GNAT bad constant patches are integrated in upstream so we don't need them anymore.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.2.0_gnat.patch R util/crossgcc/patches/gcc-9.2.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum M util/xcompile/xcompile 9 files changed, 5 insertions(+), 21,172 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/28

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 28 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

3:18 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Hello Jacob Garber, Jett Rink, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#29).

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

crossgcc: Upgrade GCC to 9.2.0

nds32 and GNAT bad constant patches are integrated in upstream so we don't need them anymore.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.2.0_gnat.patch R util/crossgcc/patches/gcc-9.2.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum 8 files changed, 2 insertions(+), 21,171 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/29

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 29 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

12 Dec 12 Dec

8:19 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Hello Jacob Garber, Jett Rink, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#30).

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

crossgcc: Upgrade GCC to 9.2.0

nds32 and GNAT bad constant patches are integrated in upstream so we don't need them anymore.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.2.0_gnat.patch R util/crossgcc/patches/gcc-9.2.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum M util/xcompile/xcompile 9 files changed, 3 insertions(+), 21,174 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/30

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 30 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

8:22 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 30:

(1 comment)

https://review.coreboot.org/c/coreboot/+/32564/30/util/xcompile/xcompile File util/xcompile/xcompile:

https://review.coreboot.org/c/coreboot/+/32564/30/util/xcompile/xcompile@a18... PS30, Line 188: testcc "$GCC" "$CFLAGS_GCC -Wno-address-of-packed-member" && : CFLAGS_GCC="$CFLAGS_GCC -Wno-address-of-packed-member" '-Wno-address-of-packed-member' is not valid for Ada

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 30 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Thu, 12 Dec 2019 19:22:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jacob Garber (Code Review)

14 Dec 14 Dec

7:53 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 31: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 31 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Sat, 14 Dec 2019 18:53:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

27 Dec 27 Dec

3:38 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 31: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 31 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Fri, 27 Dec 2019 14:38:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

5:47 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 31: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 31 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Fri, 27 Dec 2019 16:47:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

6:02 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 31:

This hasn't been tested on the Google EC codebase yet, so wait to merge it until it has.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 31 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Fri, 27 Dec 2019 17:02:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

5 Feb 5 Feb

10:54 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Hello Jacob Garber, Jett Rink, build bot (Jenkins), Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32564

to look at the new patch set (#33).

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

crossgcc: Upgrade GCC to 9.2.0

nds32 and GNAT bad constant patches are integrated in upstream so we don't need them anymore.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.2.0_gnat.patch R util/crossgcc/patches/gcc-9.2.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum M util/xcompile/xcompile 9 files changed, 3 insertions(+), 21,174 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32564/33

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 33 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

8 Feb 8 Feb

8:53 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 34: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 34 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Sat, 08 Feb 2020 19:53:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jacob Garber (Code Review)

25 Feb 25 Feb

8:29 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 34:

(1 comment)

...

Patch Set 31:

This hasn't been tested on the Google EC codebase yet, so wait to merge it until it has.

What sort of test would that look like? I tried compiling the EC boards with this patch yesterday, and I didn't see any problems compared to GCC 8. (Granted this was outside of a cros chroot though.) GCC 9 has several improvements and bug fixes for LTO support, so I'd like to help get this merged.

https://review.coreboot.org/c/coreboot/+/32564/21/util/xcompile/xcompile File util/xcompile/xcompile:

https://review.coreboot.org/c/coreboot/+/32564/21/util/xcompile/xcompile@230 PS21, Line 230: GCC_CFLAGS_${TARCH}+=-Wlogical-op -Wno-address-of-packed-member

...

Yes for sure. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 34 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Tue, 25 Feb 2020 19:29:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Jett Rink (Code Review)

11:30 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 34:

...

Patch Set 34:

(1 comment)

...
Patch Set 31:

This hasn't been tested on the Google EC codebase yet, so wait to merge it until it has.

What sort of test would that look like? I tried compiling the EC boards with this patch yesterday, and I didn't see any problems compared to GCC 8. (Granted this was outside of a cros chroot though.) GCC 9 has several improvements and bug fixes for LTO support, so I'd like to help get this merged.

I am testing this out for EC boards now. I should know tomorrow, but I expect good results as one of my co-workers (Jack) recently tried 9.2.0 out on the EC boards.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 34 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Tue, 25 Feb 2020 22:30:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jett Rink (Code Review)

26 Feb 26 Feb

3:31 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 34: Code-Review+1

...

Patch Set 34:

...
Patch Set 34:

(1 comment)

...
Patch Set 31:

This hasn't been tested on the Google EC codebase yet, so wait to merge it until it has.

What sort of test would that look like? I tried compiling the EC boards with this patch yesterday, and I didn't see any problems compared to GCC 8. (Granted this was outside of a cros chroot though.) GCC 9 has several improvements and bug fixes for LTO support, so I'd like to help get this merged.

I am testing this out for EC boards now. I should know tomorrow, but I expect good results as one of my co-workers (Jack) recently tried 9.2.0 out on the EC boards.

I just confirmed that `make buildall` works for EC boards using this upgrade CL and rebuilding coreboot-sdk in a chroot. Thanks for waiting for confirmation!

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 34 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Wed, 26 Feb 2020 14:31:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

3:36 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 34: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 34 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Wed, 26 Feb 2020 14:36:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

3:36 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

crossgcc: Upgrade GCC to 9.2.0

nds32 and GNAT bad constant patches are integrated in upstream so we don't need them anymore.

Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32564 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Jett Rink jettrink@chromium.org Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch D util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch R util/crossgcc/patches/gcc-9.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-9.2.0_gnat.patch R util/crossgcc/patches/gcc-9.2.0_libgcc.patch D util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum M util/xcompile/xcompile 9 files changed, 3 insertions(+), 21,174 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Jett Rink: Looks good to me, but someone else must approve

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 35 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

4:31 p.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 35:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/896 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/895 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/894

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 35 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Wed, 26 Feb 2020 15:31:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

15 Mar 15 Mar

10:22 a.m.

New subject: Change in coreboot[master]: crossgcc: Upgrade GCC to 9.2.0

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )

Change subject: crossgcc: Upgrade GCC to 9.2.0 ......................................................................

Patch Set 35:

Breaks at least one platform. Revert is here CB:39571

-- To view, visit https://review.coreboot.org/c/coreboot/+/32564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0 Gerrit-Change-Number: 32564 Gerrit-PatchSet: 35 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Comment-Date: Sun, 15 Mar 2020 09:22:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1714

days inactive

2031

days old

coreboot-gerrit@coreboot.org

55 comments

8 participants

tags (0)

participants (8)

9elements QA (Code Review)
HAOUAS Elyes (Code Review)
Jacob Garber (Code Review)
Jett Rink (Code Review)
Martin Roth (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)