Change in coreboot[master]: mb/google/hatch/var/helios: Increase touchscreen reset delay to 120ms
Philip Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35158 )
Change subject: mb/google/hatch/var/helios: Increase touchscreen reset delay to 120ms ......................................................................
mb/google/hatch/var/helios: Increase touchscreen reset delay to 120ms
As per GT7375P programming guide rev0.4, we want to enforece a delay of 120ms after the reset is completed before HID_I2C starts.
BUG=b:140276418
Signed-off-by: Philip Chen philipchen@google.com Change-Id: Id69a9db996bcd9001ef850c50898fbd55327b4df --- M src/mainboard/google/hatch/variants/helios/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/35158/1
diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index f97f120..71e4856 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -100,7 +100,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "10" + register "generic.reset_delay_ms" = "120" register "generic.reset_off_delay_ms" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)"
Hello Paul Fagerburg, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35158
to look at the new patch set (#2).
Change subject: mb/google/hatch/var/helios: Increase touchscreen reset delay to 120ms ......................................................................
mb/google/hatch/var/helios: Increase touchscreen reset delay to 120ms
As per GT7375P programming guide rev0.4, we want to enforce a delay of 120ms after the reset is completed, before HID_I2C starts.
BUG=b:140276418
Signed-off-by: Philip Chen philipchen@google.com Change-Id: Id69a9db996bcd9001ef850c50898fbd55327b4df --- M src/mainboard/google/hatch/variants/helios/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/35158/2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35158 )
Change subject: mb/google/hatch/var/helios: Increase touchscreen reset delay to 120ms ......................................................................
Patch Set 2: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35158 )
Change subject: mb/google/hatch/var/helios: Increase touchscreen reset delay to 120ms ......................................................................
Patch Set 2: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35158 )
Change subject: mb/google/hatch/var/helios: Increase touchscreen reset delay to 120ms ......................................................................
Patch Set 2:
Would be nice if we had a way to control the report_en pin timing as well (requires >10ms after reset), GPP_H14.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35158 )
Change subject: mb/google/hatch/var/helios: Increase touchscreen reset delay to 120ms ......................................................................
Patch Set 2:
Patch Set 2:
Would be nice if we had a way to control the report_en pin timing as well (requires >10ms after reset), GPP_H14.
Is that 120ms + 10ms after reset deasserted?
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35158 )
Change subject: mb/google/hatch/var/helios: Increase touchscreen reset delay to 120ms ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Would be nice if we had a way to control the report_en pin timing as well (requires >10ms after reset), GPP_H14.
Is that 120ms + 10ms after reset deasserted?
No, 10ms after reset deassertion it is valid to set report_en. I don't see that pin exported in the device, so it must be up to the BIOS right now. We leave it high in gpio.c right now. Philip posted the datasheet in the bug for this. If it still "works," then I don't know if that pin is actually critical to the power on sequence or not.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35158 )
Change subject: mb/google/hatch/var/helios: Increase touchscreen reset delay to 120ms ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
Would be nice if we had a way to control the report_en pin timing as well (requires >10ms after reset), GPP_H14.
Is that 120ms + 10ms after reset deasserted?
No, 10ms after reset deassertion it is valid to set report_en. I don't see that pin exported in the device, so it must be up to the BIOS right now. We leave it high in gpio.c right now. Philip posted the datasheet in the bug for this. If it still "works," then I don't know if that pin is actually critical to the power on sequence or not.
There is a stop_gpio that you can potentially use for it.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35158 )
Change subject: mb/google/hatch/var/helios: Increase touchscreen reset delay to 120ms ......................................................................
mb/google/hatch/var/helios: Increase touchscreen reset delay to 120ms
As per GT7375P programming guide rev0.4, we want to enforce a delay of 120ms after the reset is completed, before HID_I2C starts.
BUG=b:140276418
Signed-off-by: Philip Chen philipchen@google.com Change-Id: Id69a9db996bcd9001ef850c50898fbd55327b4df Reviewed-on: https://review.coreboot.org/c/coreboot/+/35158 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/helios/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved Paul Fagerburg: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index f97f120..71e4856 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -100,7 +100,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "10" + register "generic.reset_delay_ms" = "120" register "generic.reset_off_delay_ms" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)"
-
Furquan Shaikh (Code Review) -
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)
-
Philip Chen (Code Review)
-
Tim Wawrzynczak (Code Review)