Attention is currently required from: Lance Zhao, Tarun Tuli, Subrata Banik, Tim Wawrzynczak.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70063 )
Change subject: acpi: Helper functions to add certain _DSD properties ......................................................................
Patch Set 8:
(1 comment)
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/70063/comment/0f1cc15f_b5cb5f65 PS7, Line 1203: /* : * Below properties are defined at : * https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-r... : */ : #define ACPI_DSD_EXTERNAL_FACING_PORT_UUID "EFCC06CC-73AC-4BC3-BFF0-76143807C389" : #define ACPI_DSD_EXTERNAL_FACING_PORT_NAME "ExternalFacingPort" : : #define ACPI_DSD_HOTPLUG_IN_D3_UUID "6211E2C0-58A3-4AF3-90E1-927A4E0C55A4" : #define ACPI_DSD_HOTPLUG_IN_D3_NAME "HotPlugSupportInD3" : : /* ID for the DmaProperty _DSD */ : #define ACPI_DSD_DMA_PROPERTY_UUID "70D24161-6DD5-4C9E-8070-705531292865" : #define ACPI_DSD_DMA_PROPERTY_NAME "DmaProperty" : : /* : * Below properties are defined at : * https://docs.microsoft.com/en-us/windows-hardware/design/component-guideline... : */ : #define ACPI_DSD_STORAGE_D3_UUID "5025030F-842F-4AB4-A561-99A5189762D0" : #define ACPI_DSD_STORAGE_D3_NAME "StorageD3Enable"
i would have move all these macros at the startng of the file
Ack