Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34990 )
Change subject: mediatek/mt8183: Use different DRAM frequencies for eMCP DDR
......................................................................
Patch Set 33:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34990/32/src/soc/mediatek/mt8183/em...
File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/34990/32/src/soc/mediatek/mt8183/em...
PS32, Line 22: ic const u8 const freq_shuffle[DRAM_DFS_SHUFFLE_MAX] = {
: [DRAM_DFS_SHUFFLE_1] = LP4X_DDR3200,
: [DRAM_DFS_SHUFFLE_2] = LP4X_DDR2400,
: [DRAM_DFS_SHUFFLE_3] = LP4X_DDR1600,
: };
: static const u8 const freq_shuffle_emcp[DRAM_DFS_SHUFFLE_MAX] = {
: [DRAM_DFS_SHUFFLE_1] = LP4X_DDR3600,
: [DRAM_DFS_SHUFFLE_2] = LP4X_DDR3200,
: [DRAM_DFS_SHUFFLE_3] = LP4X_DDR1600,
: };
How about this: […]
it seem good.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34990
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab6a9c2c390feeb9497b051a255b29566909e656
Gerrit-Change-Number: 34990
Gerrit-PatchSet: 33
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 20 Sep 2019 07:59:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-MessageType: comment