[M] Change in coreboot[main]: drivers/wifi/generic: Add Methods to control CNVi enable GPIO - coreboot-gerrit

14 Feb 2025


      Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86402?usp=email )
Change subject: drivers/wifi/generic: Add Methods to control CNVi enable GPIO
......................................................................
Patch Set 8:
(1 comment)
File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/86402/comment/121a8aee_783fceaf?usp... :
PS8, Line 1240: #if CONFIG(SOC_INTEL_COMMON_BLOCK_CNVI)
you can use a single `#if` block here for the whole thing, since `wifi_cnvi_fill_ssdt` is only used/referenced if the Kconfig is selected
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/86402?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I09d0011ede6f739511a61daf2f1b317f6500a343
Gerrit-Change-Number: 86402
Gerrit-PatchSet: 8
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Comment-Date: Fri, 14 Feb 2025 19:57:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No