Change in coreboot[master]: util/amdfwtool: silence compiler on FreeBSD

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Idwer Vollering (Code Review)

16 Dec 2019 16 Dec '19

2:52 p.m.

Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37766 )

Change subject: util/amdfwtool: silence compiler on FreeBSD ......................................................................

util/amdfwtool: silence compiler on FreeBSD

Change-Id: Ida2c1f36aba7469d69dbb12ee6afce4a181bd6b7 Signed-off-by: Idwer Vollering vidwer@gmail.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/37766/1

diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 02564cf..b5cad76 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -110,10 +110,12 @@ */ #define PSP_COMBO 0

+#if !defined(__FreeBSD__) typedef unsigned long long int uint64_t; typedef unsigned int uint32_t; typedef unsigned char uint8_t; typedef unsigned short uint16_t; +#endif

/* * Creates the OSI Fletcher checksum. See 8473-1, Appendix C, section C.3.

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Paul Menzel (Code Review)

16 Dec 16 Dec

2:59 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37766 )

Change subject: util/amdfwtool: silence compiler on FreeBSD ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37766/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37766/1//COMMIT_MSG@7 PS1, Line 7: util/amdfwtool: silence compiler on FreeBSD Maybe:

...

Guard macros on FreeBSD

-- To view, visit https://review.coreboot.org/c/coreboot/+/37766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida2c1f36aba7469d69dbb12ee6afce4a181bd6b7 Gerrit-Change-Number: 37766 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 16 Dec 2019 14:59:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Idwer Vollering (Code Review)

17 Dec 17 Dec

12:03 a.m.

New subject: Change in coreboot[master]: util/amdfwtool: guard typedef aliases on FreeBSD

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37766

to look at the new patch set (#2).

Change subject: util/amdfwtool: guard typedef aliases on FreeBSD ......................................................................

util/amdfwtool: guard typedef aliases on FreeBSD

Change-Id: Ida2c1f36aba7469d69dbb12ee6afce4a181bd6b7 Signed-off-by: Idwer Vollering vidwer@gmail.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/37766/2

Idwer Vollering (Code Review)

19 Jan 19 Jan

9:09 p.m.

New subject: Change in coreboot[master]: util/amdfwtool: guard typedef aliases

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37766

to look at the new patch set (#3).

Change subject: util/amdfwtool: guard typedef aliases ......................................................................

util/amdfwtool: guard typedef aliases

Build tested on Ubuntu 18 LTS, FreeBSD.

Change-Id: Ida2c1f36aba7469d69dbb12ee6afce4a181bd6b7 Signed-off-by: Idwer Vollering vidwer@gmail.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/37766/3

Patrick Georgi (Code Review)

20 Jan 20 Jan

2:43 p.m.

New subject: Change in coreboot[master]: util/amdfwtool: guard typedef aliases

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37766 )

Change subject: util/amdfwtool: guard typedef aliases ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida2c1f36aba7469d69dbb12ee6afce4a181bd6b7 Gerrit-Change-Number: 37766 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 20 Jan 2020 14:43:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2:43 p.m.

New subject: Change in coreboot[master]: util/amdfwtool: guard typedef aliases

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37766 )

Change subject: util/amdfwtool: guard typedef aliases ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37766/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37766/1//COMMIT_MSG@7 PS1, Line 7: util/amdfwtool: silence compiler on FreeBSD

...

Maybe: […]

Different approach used now, commit message is fine, too.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida2c1f36aba7469d69dbb12ee6afce4a181bd6b7 Gerrit-Change-Number: 37766 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 20 Jan 2020 14:43:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2:43 p.m.

New subject: Change in coreboot[master]: util/amdfwtool: guard typedef aliases

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37766 )

Change subject: util/amdfwtool: guard typedef aliases ......................................................................

util/amdfwtool: guard typedef aliases

Build tested on Ubuntu 18 LTS, FreeBSD.

Change-Id: Ida2c1f36aba7469d69dbb12ee6afce4a181bd6b7 Signed-off-by: Idwer Vollering vidwer@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37766 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 39cc45f..d5c63de 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -110,10 +110,12 @@ */ #define PSP_COMBO 0

+#if defined(__GLIBC__) typedef unsigned long long int uint64_t; typedef unsigned int uint32_t; typedef unsigned char uint8_t; typedef unsigned short uint16_t; +#endif

/* * Creates the OSI Fletcher checksum. See 8473-1, Appendix C, section C.3.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida2c1f36aba7469d69dbb12ee6afce4a181bd6b7 Gerrit-Change-Number: 37766 Gerrit-PatchSet: 4 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

3:08 p.m.

New subject: Change in coreboot[master]: util/amdfwtool: guard typedef aliases

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37766 )

Change subject: util/amdfwtool: guard typedef aliases ......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/193 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/192 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/191

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/37766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida2c1f36aba7469d69dbb12ee6afce4a181bd6b7 Gerrit-Change-Number: 37766 Gerrit-PatchSet: 4 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 20 Jan 2020 15:08:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1714

days inactive

1749

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

9elements QA (Code Review)
Idwer Vollering (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)