Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Ivy Jian, Eric Lai, Ronak Kanabar.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74161 )
Change subject: soc/intel/meteorlake: Enable VMX
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74161/comment/4856eeca_9d36f6b9
PS3, Line 7: soc/intel/meteorlake: Enable VMX
Reading the diff, it’s only related to `DROP_CPU_FEATURE_PROGRAM_IN_FSP`?
https://review.coreboot.org/c/coreboot/+/74161/comment/ac36245a_23dc7127
PS3, Line 11:
Shouldn’t VMX programming be left to the payload or OS? […]
I think it was discussed in the past, that coreboot does not need to do it, but it looks like there is `ENABLE_VMX` already in Intel’s common code. I was just confused by the commit message summary/title.
File src/soc/intel/meteorlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/74161/comment/99d88725_7d3a464e
PS3, Line 149: Vmx
VMX
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74161
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e49c15fd4f78a3e633855fea550720f0a685062
Gerrit-Change-Number: 74161
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Sun, 02 Apr 2023 14:22:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment