Change in coreboot[master]: Revert "lynxpoint: Fix SerialIO ACPI compile issue with recent IASL"
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46955 )
Change subject: Revert "lynxpoint: Fix SerialIO ACPI compile issue with recent IASL" ......................................................................
Revert "lynxpoint: Fix SerialIO ACPI compile issue with recent IASL"
This reverts commit 1a25c9cdfd3fd391328133ba94c63ecd1083e4f8.
Reason for revert: No longer necessary.
Change-Id: I8adeeebd6e841ef2c878622559dcd15848969842 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/lynxpoint/acpi/gpio.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/46955/1
diff --git a/src/southbridge/intel/lynxpoint/acpi/gpio.asl b/src/southbridge/intel/lynxpoint/acpi/gpio.asl index 358bdec..6ae1f0f 100644 --- a/src/southbridge/intel/lynxpoint/acpi/gpio.asl +++ b/src/southbridge/intel/lynxpoint/acpi/gpio.asl @@ -18,7 +18,7 @@ 0x00000000, // AddressMinimum 0x00000000, // AddressMaximum 0x00000000, // AddressTranslation - 0x00000001, // RangeLength + 0x00000000, // RangeLength , // ResourceSourceIndex , // ResourceSource BAR0)
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46955
to look at the new patch set (#5).
Change subject: Revert "lynxpoint: Fix SerialIO ACPI compile issue with recent IASL" ......................................................................
Revert "lynxpoint: Fix SerialIO ACPI compile issue with recent IASL"
This reverts commit 1a25c9cdfd3fd391328133ba94c63ecd1083e4f8.
Reason for revert: No longer necessary.
Change-Id: I8adeeebd6e841ef2c878622559dcd15848969842 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/lynxpoint/acpi/gpio.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/46955/5
Attention is currently required from: Angel Pons. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46955 )
Change subject: Revert "lynxpoint: Fix SerialIO ACPI compile issue with recent IASL" ......................................................................
Patch Set 8: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46955 )
Change subject: Revert "lynxpoint: Fix SerialIO ACPI compile issue with recent IASL" ......................................................................
Revert "lynxpoint: Fix SerialIO ACPI compile issue with recent IASL"
This reverts commit 1a25c9cdfd3fd391328133ba94c63ecd1083e4f8.
Reason for revert: No longer necessary.
Change-Id: I8adeeebd6e841ef2c878622559dcd15848969842 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46955 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/intel/lynxpoint/acpi/gpio.asl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/southbridge/intel/lynxpoint/acpi/gpio.asl b/src/southbridge/intel/lynxpoint/acpi/gpio.asl index 2e432ad..a673b25 100644 --- a/src/southbridge/intel/lynxpoint/acpi/gpio.asl +++ b/src/southbridge/intel/lynxpoint/acpi/gpio.asl @@ -18,7 +18,7 @@ 0x00000000, // AddressMinimum 0x00000000, // AddressMaximum 0x00000000, // AddressTranslation - 0x00000001, // RangeLength + 0x00000000, // RangeLength , // ResourceSourceIndex , // ResourceSource BAR0)
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)