Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49126 )
Change subject: util/testing: Build test all our tools ......................................................................
util/testing: Build test all our tools
https://qa.coreboot.org/job/untested-coreboot-files reports a bunch of untouched Makefiles, so we never even attempt to build those tools.
This commit currently doesn't build and serves as a reminder that there are tools to fix.
Change-Id: Ib6378dbaef9787b3cd3e047068d01c73927fa73f Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/testing/Makefile.inc 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/49126/1
diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc index da6db60..ad30514 100644 --- a/util/testing/Makefile.inc +++ b/util/testing/Makefile.inc @@ -61,7 +61,9 @@ intelvbttool \ nvramtool \ post \ -superiotool +superiotool \ +uio_usbdebug \ +vgabios
TEST_PAYLOADLIST_INTERNAL= \ coreinfo \
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49126 )
Change subject: util/testing: Build test all our tools ......................................................................
Patch Set 1: Code-Review+2
And this is why they need to be build tested.
This patch looks good, but the tools need to be fixed before it can be merged.
Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/49126 )
Change subject: util/testing: Build test all our tools ......................................................................
Abandoned