Change in coreboot[master]: soc/mediatek/mt8186: Add support for PMIC MT6366 - coreboot-gerrit

12 Nov 2021


      Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59245 )
Change subject: soc/mediatek/mt8186: Add support for PMIC MT6366
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/mt8186/mt6366.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133125):
https://review.coreboot.org/c/coreboot/+/59245/comment/3f5d64d8_ec37b340 
PS3, Line 708: 	while (!stopwatch_expired(&voltage_settled))
suspect code indent for conditional statements (8, 49)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59245
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22e30421560a32f4a9e15899e8150376b1414494
Gerrit-Change-Number: 59245
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Yu-Ping Wu yupingso@google.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Fri, 12 Nov 2021 09:40:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment