[S] Change in coreboot[master]: cpu/intel/socket_*: Clean up Kconfig files - coreboot-gerrit

18 Nov 2022


      Attention is currently required from: Stefan Ott, Nico Huber, Arthur Heymans, Kyösti Mälkki, Alexander Couzens, Elyes Haouas.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69447 )
Change subject: cpu/intel/socket_*: Clean up Kconfig files
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/cpu/intel/socket_BGA956/Kconfig:
https://review.coreboot.org/c/coreboot/+/69447/comment/491de430_80df5d44 
PS4, Line 9: 	select MMX
...
Shouldn't MMX be selected by the CPU?
It's not even used. You can remove CONFIG_MMX, and we can probably assume all x86 CPUs have MMX.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69447
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2265ac716e90720e7ccc550239737d40c2f7a0a
Gerrit-Change-Number: 69447
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Stefan Ott coreboot@desire.ch
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Stefan Ott coreboot@desire.ch
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 18 Nov 2022 17:24:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment