[M] Change in coreboot[main]: mb/google/fatcat/variants/fatcat: Enable BT audio offload

[Uday Bhat (Code Review)]

Attention is currently required from: Jayvik Desai, Kapil Porwal, Naveen M, Pranava Y N, Subrata Banik.

Uday Bhat has posted comments on this change by Uday Bhat. ( https://review.coreboot.org/c/coreboot/+/86121?usp=email )

Change subject: mb/google/fatcat/variants/fatcat: Enable BT audio offload
......................................................................

Patch Set 2:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/86121/comment/ca4b3bea_edabe777?usp... :
PS1, Line 12: I2S and soundwire
> I see that the pads are configured in case of HDA as well, so I was just wondering

BT offload is not enabled for HDA till now (not even in previous platforms). Hence, disabled these pads for HDA

File src/mainboard/google/fatcat/variants/fatcat/fw_config.c:

https://review.coreboot.org/c/coreboot/+/86121/comment/5f460bf1_4b2d0eaa?usp... :
PS1, Line 88: static const struct pad_config bt_i2s_enable_pads[] = {
> Disable these pads in `AUDIO_NONE` configuration?

Done

https://review.coreboot.org/c/coreboot/+/86121/comment/8bd35afe_d6d16913?usp... :
PS1, Line 578: 	else if (fw_config_probe(FW_CONFIG(AUDIO, AUDIO_ALC256_HDA))) {
> > `else should follow close brace '}'` […]

Done

File src/mainboard/google/fatcat/variants/fatcat/variant.c:

https://review.coreboot.org/c/coreboot/+/86121/comment/86f0f3fe_45f218ef?usp... :
PS1, Line 17: 	printk(BIOS_INFO, "Configure BT audio offload config.\n");
> This log message seems redundant.

Acknowledged

https://review.coreboot.org/c/coreboot/+/86121/comment/51ce932c_9bb29698?usp... :
PS1, Line 24: config->cnvi_bt_audio_offload = true;
> Shouldn't setting this also depend on the `AUDIO` configs?

Done