Change in coreboot[master]: soc/intel/common/block/lpc: create LPC_GET_DEV macro

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30209 )

Change subject: soc/intel/common/block/lpc: create LPC_GET_DEV macro
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/30209/2/src/soc/intel/common/block/... 
File src/soc/intel/common/block/lpc/lpc_lib.c:

https://review.coreboot.org/c/coreboot/+/30209/2/src/soc/intel/common/block/... 
PS2, Line 29: #if !defined(__SIMPLE_DEVICE__)
            : #include <device/device.h>
            : #define LPC_GET_DEV pcidev_on_root(PCH_DEV_SLOT_LPC, 0x0)
            : #else
            : #define LPC_GET_DEV PCH_DEV_LPC
            : #endif
> would this be inherently taken care by: […]

right now we have a 
#define __SIMPLE_DEVICE__ guard at line 18
https://review.coreboot.org/c/coreboot/+/30209/2/src/soc/intel/common/block/...

this tells all PCH_DEV_LPC reference to go to simple device check in entire file.

problem is this file only complies to simple_device as we have guard above. after deleting tha guard, ramstage has started giving error as below (because of fetching code from !__SIMPLE_DEVICE__  in pch_devs.h)

CC         ramstage/soc/intel/common/block/lpc/lpc_lib.o
In file included from 
src/soc/intel/common/block/lpc/lpc_lib.c:27:
src/soc/intel/common/block/lpc/lpc_lib.c: In function 'lpc_set_bios_control_reg':
src/soc/intel/cannonlake/include/soc/pci_devs.h:26:30: error: initialization of 'pci_devfn_t' {aka 'unsigned in '} from 'struct device *' makes integer from pointer without a cast [-Werror=int-conversion]
 #define _PCH_DEV(slot, func) pcidev_path_on_root_debug(_PCH_DEVFN(slot, func), __func__)
                              ^~~~~~~~~~~~~~~~~~~~~~~~~
src/soc/intel/cannonlake/include/soc/pci_devs.h:187:23: note: in expansion of macro '_PCH_DEV'
 #define  PCH_DEV_LPC  _PCH_DEV(LPC, 0)
                       ^~~~~~~~
src/soc/intel/common/block/lpc/lpc_lib.c:179:20: note: in expansion of macro 'PCH_DEV_LPC'
  pci_devfn_t dev = PCH_DEV_LPC;
                    ^~~~~~~~~~~
src/soc/intel/common/block/lpc/lpc_lib.c:183:29: error: passing argument 1 of 'pci_read_config8' makes pointer from integer without a cast [-Werror=int-conversion]
  bc_cntl = pci_read_config8(dev, LPC_BIOS_CNTL);
                             ^~~