Divya S Sasidharan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37867 )
Change subject: src/ec/google/chromeec: Get Type-C Mux info from EC ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37867/2/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/37867/2/src/ec/google/chromeec/ec.c... PS2, Line 1417: #define PD_CC_DFP_ATTACHED 5 : #define PD_CC_DEBUG_ACC 6 :
how about adding enum pd_cc_states {} from ec_commands. […]
Sure can add that.
https://review.coreboot.org/c/coreboot/+/37867/2/src/ec/google/chromeec/ec.c... PS2, Line 1434: cmd.cmd_code = EC_CMD_USB_PD_CONTROL; : cmd.cmd_version = 3; : cmd.cmd_data_in = &pd_control; : cmd.cmd_size_in = sizeof(pd_control); : cmd.cmd_data_out = &resp; : cmd.cmd_size_out = sizeof(resp); : cmd.cmd_dev_index = 0;
how about adding common code for all these like in extcon driver?
Its a good idea.
https://review.coreboot.org/c/coreboot/+/37867/2/src/ec/google/chromeec/ec_c... File src/ec/google/chromeec/ec_commands.h:
https://review.coreboot.org/c/coreboot/+/37867/2/src/ec/google/chromeec/ec_c... PS2, Line 4993: } __ec_align1;
Why can’t this struct not be extended?
True. The new EC code base has inculcated this change. Also more cleanup here to be merged in EC https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2013825. Updating this patch accordingly.
-
Divya S Sasidharan (Code Review)