Change in coreboot[master]: ec/google/chromeec/acpi: Move ECPD under CREC

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Prashant Malani (Code Review)

12 Mar 2020 12 Mar '20

5:34 a.m.

Prashant Malani has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39469 )

Change subject: ec/google/chromeec/acpi: Move ECPD under CREC ......................................................................

ec/google/chromeec/acpi: Move ECPD under CREC

Move the ECPD (GOOG0003) device under CREC (GOOG0004) so that the ECPD AP device drivers can access the parent EC device to communicate with the EC. Also, update the Notify() call to reflect the new location of the ECPD device.

Signed-off-by: Prashant Malani pmalani@chromium.org Change-Id: I830b030c7a063506f50f9cd51df3a5018e248fc2 --- M src/ec/google/chromeec/acpi/cros_ec.asl M src/ec/google/chromeec/acpi/ec.asl 2 files changed, 5 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/39469/1

diff --git a/src/ec/google/chromeec/acpi/cros_ec.asl b/src/ec/google/chromeec/acpi/cros_ec.asl index d41071e..bcf38d2 100644 --- a/src/ec/google/chromeec/acpi/cros_ec.asl +++ b/src/ec/google/chromeec/acpi/cros_ec.asl @@ -60,6 +60,10 @@ Name (_DDN, "EC Base Switch Device") } #endif + +#ifdef EC_ENABLE_PD_MCU_DEVICE + #include "pd.asl" +#endif Method(_STA, 0) { Return (0xB) diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index bf792d3..fa5eca6 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -344,7 +344,7 @@ Method (_Q16, 0, NotSerialized) { Store ("EC: GOT PD EVENT", Debug) - Notify (ECPD, 0x80) + Notify (_SB.PCI0.LPCB.EC0.CREC.ECPD, 0x80) } #endif

@@ -558,10 +558,6 @@ #include "keyboard_backlight.asl" #endif

-#ifdef EC_ENABLE_PD_MCU_DEVICE - #include "pd.asl" -#endif - #ifdef EC_ENABLE_TBMC_DEVICE #include "tbmc.asl" #endif

Attachments:

attachment.htm (text/html — 3.9 KB)

Show replies by date

Prashant Malani (Code Review)

12 Mar 12 Mar

5:35 a.m.

Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39469 )

Change subject: ec/google/chromeec/acpi: Move ECPD under CREC ......................................................................

Patch Set 1:

Hey Furquan, PTAL.

Thanks!

Duncan Laurie (Code Review)

11:36 a.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39469 )

Change subject: ec/google/chromeec/acpi: Move ECPD under CREC ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I830b030c7a063506f50f9cd51df3a5018e248fc2 Gerrit-Change-Number: 39469 Gerrit-PatchSet: 1 Gerrit-Owner: Prashant Malani pmalani@chromium.org Gerrit-Assignee: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 12 Mar 2020 16:36:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

11:51 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39469 )

Change subject: ec/google/chromeec/acpi: Move ECPD under CREC ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I830b030c7a063506f50f9cd51df3a5018e248fc2 Gerrit-Change-Number: 39469 Gerrit-PatchSet: 1 Gerrit-Owner: Prashant Malani pmalani@chromium.org Gerrit-Assignee: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 12 Mar 2020 16:51:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Prashant Malani (Code Review)

8:29 p.m.

Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39469 )

Change subject: ec/google/chromeec/acpi: Move ECPD under CREC ......................................................................

Patch Set 1:

Thanks for the quick reviews.

Since I lack V+1 or Submit privileges in Coreboot, could someone kindly flip those bits for this CL?

-- To view, visit https://review.coreboot.org/c/coreboot/+/39469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I830b030c7a063506f50f9cd51df3a5018e248fc2 Gerrit-Change-Number: 39469 Gerrit-PatchSet: 1 Gerrit-Owner: Prashant Malani pmalani@chromium.org Gerrit-Assignee: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 13 Mar 2020 01:29:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Duncan Laurie (Code Review)

8:30 p.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39469 )

Change subject: ec/google/chromeec/acpi: Move ECPD under CREC ......................................................................

Patch Set 1:

V+1 got set by the bot so it is good there. I can submit after giving 24h for the community to poke at it.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I830b030c7a063506f50f9cd51df3a5018e248fc2 Gerrit-Change-Number: 39469 Gerrit-PatchSet: 1 Gerrit-Owner: Prashant Malani pmalani@chromium.org Gerrit-Assignee: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 13 Mar 2020 01:30:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:30 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39469 )

Change subject: ec/google/chromeec/acpi: Move ECPD under CREC ......................................................................

Patch Set 1:

...

Patch Set 1:

Thanks for the quick reviews.

Since I lack V+1 or Submit privileges in Coreboot, could someone kindly flip those bits for this CL?

We need to wait for 24 hours before the change can be submitted. Patrick typically takes care of submitting the CL and cherry-picking to chromium tree.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I830b030c7a063506f50f9cd51df3a5018e248fc2 Gerrit-Change-Number: 39469 Gerrit-PatchSet: 1 Gerrit-Owner: Prashant Malani pmalani@chromium.org Gerrit-Assignee: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 13 Mar 2020 01:30:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Prashant Malani (Code Review)

8:49 p.m.

Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39469 )

Change subject: ec/google/chromeec/acpi: Move ECPD under CREC ......................................................................

Patch Set 1:

...

Patch Set 1:

...
Patch Set 1:

Thanks for the quick reviews.

Since I lack V+1 or Submit privileges in Coreboot, could someone kindly flip those bits for this CL?

We need to wait for 24 hours before the change can be submitted. Patrick typically takes care of submitting the CL and cherry-picking to chromium tree.

Got it. Thanks!

-- To view, visit https://review.coreboot.org/c/coreboot/+/39469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I830b030c7a063506f50f9cd51df3a5018e248fc2 Gerrit-Change-Number: 39469 Gerrit-PatchSet: 1 Gerrit-Owner: Prashant Malani pmalani@chromium.org Gerrit-Assignee: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 13 Mar 2020 01:49:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

13 Mar 13 Mar

5 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39469 )

Change subject: ec/google/chromeec/acpi: Move ECPD under CREC ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/39469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I830b030c7a063506f50f9cd51df3a5018e248fc2 Gerrit-Change-Number: 39469 Gerrit-PatchSet: 1 Gerrit-Owner: Prashant Malani pmalani@chromium.org Gerrit-Assignee: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 13 Mar 2020 10:00:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Duncan Laurie (Code Review)

9:42 p.m.

Duncan Laurie has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39469 )

Change subject: ec/google/chromeec/acpi: Move ECPD under CREC ......................................................................

ec/google/chromeec/acpi: Move ECPD under CREC

Signed-off-by: Prashant Malani pmalani@chromium.org Change-Id: I830b030c7a063506f50f9cd51df3a5018e248fc2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/39469 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/ec/google/chromeec/acpi/cros_ec.asl M src/ec/google/chromeec/acpi/ec.asl 2 files changed, 5 insertions(+), 5 deletions(-)

Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved

@@ -558,10 +558,6 @@ #include "keyboard_backlight.asl" #endif

-#ifdef EC_ENABLE_PD_MCU_DEVICE - #include "pd.asl" -#endif - #ifdef EC_ENABLE_TBMC_DEVICE #include "tbmc.asl" #endif

-- To view, visit https://review.coreboot.org/c/coreboot/+/39469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I830b030c7a063506f50f9cd51df3a5018e248fc2 Gerrit-Change-Number: 39469 Gerrit-PatchSet: 2 Gerrit-Owner: Prashant Malani pmalani@chromium.org Gerrit-Assignee: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

10:22 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39469 )

Change subject: ec/google/chromeec/acpi: Move ECPD under CREC ......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1340 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1339 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1338

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/39469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I830b030c7a063506f50f9cd51df3a5018e248fc2 Gerrit-Change-Number: 39469 Gerrit-PatchSet: 2 Gerrit-Owner: Prashant Malani pmalani@chromium.org Gerrit-Assignee: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Sat, 14 Mar 2020 03:22:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1829

days inactive

1831

days old

coreboot-gerrit@coreboot.org

10 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Duncan Laurie (Code Review)
Furquan Shaikh (Code Review)
Paul Menzel (Code Review)
Prashant Malani (Code Review)