[M] Change in coreboot[master]: cpu/x86/smm: Add PCI BAR store functionality

[Martin Roth (Code Review)]

Attention is currently required from: Arthur Heymans, Robert Zieba, Nico Huber, Angel Pons, Karthik Ramasubramanian, Felix Held.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67931 )

Change subject: cpu/x86/smm: Add PCI BAR store functionality
......................................................................

Patch Set 7: Code-Review+2

(2 comments)

File src/cpu/x86/smm/pci_bar_store.c:

https://review.coreboot.org/c/coreboot/+/67931/comment/1dc05624_24c5c650 
PS7, Line 18: 
nit: extra line

https://review.coreboot.org/c/coreboot/+/67931/comment/9ef08e8f_f5c37b9a 
PS7, Line 20: if (num_devices > num_slots) {
            : 		printk(BIOS_ERR, "Failed to store PCI BARs, number of devices exceeds slots\n");
            : 		return false;
            : 	}
nit: Would it make sense to do this check inside the for loop so that it can store what bars it can, especially since a device could be skipped if it's not in the resource list.

Can this be turned into a static assert so it fails at build time?

Use a regular assert so that it halts if fatal asserts are enabled?

Feel free to look at this in a follow-on if any of it makes sense.