Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35403 )
Change subject: soc/intel/common/basecode: Implement CSE update flow ......................................................................
Patch Set 14:
(3 comments)
Documentation is still missing.
https://review.coreboot.org/c/coreboot/+/35403/14/src/soc/intel/common/basec... File src/soc/intel/common/basecode/fw_update/cse_update.c:
https://review.coreboot.org/c/coreboot/+/35403/14/src/soc/intel/common/basec... PS14, Line 33: #define CBFS_SI_ME "SI_ME" should be defined in a common header, discussable if that should be in commonlib same for the following defines
https://review.coreboot.org/c/coreboot/+/35403/14/src/soc/intel/common/basec... PS14, Line 85: printk(BIOS_DEBUG, "Failed to get start/end offset of partition:%d\n", add prefix to all printk messages
https://review.coreboot.org/c/coreboot/+/35403/14/src/soc/intel/common/basec... File src/soc/intel/common/basecode/include/intelbasecode/cse_update.h:
https://review.coreboot.org/c/coreboot/+/35403/14/src/soc/intel/common/basec... PS14, Line 17: #ifndef SOC_INTEL_COMMONBASE_UCODE_UPD_H seems to be copied from somewhere
-
Patrick Rudolph (Code Review)