Attention is currently required from: Haribalaraman Ramasubramanian, Dinesh Gehlot, Rizwan Qureshi, Reka Norman, Kapil Porwal, Sridhar Siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 )
Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details
......................................................................
Patch Set 19:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74005/comment/0094c3e1_1de6413d
PS1, Line 10: version details of ISHC.
The query was about an older description. The description has since been updated to reflect the changes in implementation. The current implementation of the API retrieves partition information, and it is not specific to ISHC. In subsequent changes, the API will be used to retrieve ISHC version.
I understand your suggestion to include the purpose of ISHC retrieval in the description. I will include that information in the pertinent subsequent changelist.
@Dinesh, please add the details in the commit msg itself.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74005
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8
Gerrit-Change-Number: 74005
Gerrit-PatchSet: 19
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: SRIDHAR SIRICILLA
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Mon, 10 Apr 2023 06:03:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Dinesh Gehlot
digehlot@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment