Change in coreboot[master]: soc/amd/picasso/acpi: Remove dummy AOAC parent device - coreboot-gerrit

22 Jan 2021


      Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49814 )
Change subject: soc/amd/picasso/acpi: Remove dummy AOAC parent device
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/picasso/acpi/sb_fch.asl:
https://review.coreboot.org/c/coreboot/+/49814/comment/5ba1cd66_dcbdb4ca 
PS1, Line 127: 11
out of scope of this patch, but it would be good to use the defines from soc/southbridge.h here. probably factoring out those definitions would be a good idea to not turn that file into a preprocessor mess in order to be included in the asl file
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49814
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd4a94baa4358ee4f15c461a5bb54ca925023a13
Gerrit-Change-Number: 49814
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Fri, 22 Jan 2021 01:25:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment