Attention is currently required from: Daniel Peng, Derek Huang, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Simon Yang, Subrata Banik, Sumeet R Pawnikar.
Paul Menzel has posted comments on this change by Simon Yang. ( https://review.coreboot.org/c/coreboot/+/82682?usp=email )
Change subject: soc/intel/alderlake: Add Vccin Aux Imon Iccmax setting
......................................................................
Patch Set 11:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82682/comment/a635626a_dd538317?usp... :
PS11, Line 12: 27000(27A)
Please add a space before the (.
https://review.coreboot.org/c/coreboot/+/82682/comment/1c7da657_cd2545be?usp... :
PS11, Line 12: hard code to
is hard coded to
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/82682/comment/73e0e79b_6561505a?usp... :
PS11, Line 782: ONLY
only
https://review.coreboot.org/c/coreboot/+/82682/comment/b5fc66d4_b1d36d2b?usp... :
PS11, Line 783: 27000(27A)
Please add a space before the (.
https://review.coreboot.org/c/coreboot/+/82682/comment/7c9cad46_ffd3ace5?usp... :
PS11, Line 783: Default is set to 27000(27A)
Defaults to …
https://review.coreboot.org/c/coreboot/+/82682/comment/9eb923ca_284a335a?usp... :
PS11, Line 784: Range
*Allowed values* or something similar?
https://review.coreboot.org/c/coreboot/+/82682/comment/f5f3e147_72582696?usp... :
PS11, Line 786: uint16_t vccin_aux_imon_iccmax
Could it be made an enum?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82682?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0651f0eb8a5c32b27c524e43bbf6f2a184b95657
Gerrit-Change-Number: 82682
Gerrit-PatchSet: 11
Gerrit-Owner: Simon Yang
simon1.yang@intel.com
Gerrit-Reviewer: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Mon, 05 Aug 2024 07:48:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No