Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19931 )
Change subject: purism/librem13v1: Rename librem13 to librem13v1 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19931/1/src/mainboard/purism/librem13v1/Kcon... File src/mainboard/purism/librem13v1/Kconfig:
PS1, Line 38: Librem 13 v1
I think this goes into smbios. flashrom complains if its not the same as ve
Yes, it goes into the SMBIOS table. That's the point. Flashrom doesn't complain (we have to use the laptop=force_I_want_a_brick anyways, so maybe that disables the warning, or I just never noticed it).
Anyways, the original firmware had it set to : Manufacturer: Intel Corporation Product Name: SharkBay Platform Which is very annoying (because it's generic and it's the same values on librem13 and librem15), and this is meant to allow Purism to differentiate their hardware in the future using the smbios value.
-
Youness Alaoui (Code Review)