HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37843 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
mainboard: Add missing include <device/pci_def.h>
Change-Id: I8a7c989540e8b62de7fd291f695adac849f4680c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/gardenia/irq_tables.c M src/mainboard/aopen/dxplplusu/acpi_tables.c M src/mainboard/asrock/e350m1/irq_tables.c M src/mainboard/asrock/imb-a180/irq_tables.c M src/mainboard/emulation/qemu-i440fx/northbridge.c M src/mainboard/gizmosphere/gizmo/irq_tables.c M src/mainboard/pcengines/apu1/irq_tables.c M src/mainboard/pcengines/apu2/irq_tables.c 8 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/37843/1
diff --git a/src/mainboard/amd/gardenia/irq_tables.c b/src/mainboard/amd/gardenia/irq_tables.c index bf1daec..3af2757 100644 --- a/src/mainboard/amd/gardenia/irq_tables.c +++ b/src/mainboard/amd/gardenia/irq_tables.c @@ -15,6 +15,7 @@
#include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/aopen/dxplplusu/acpi_tables.c b/src/mainboard/aopen/dxplplusu/acpi_tables.c index cc6835b..70bfa27 100644 --- a/src/mainboard/aopen/dxplplusu/acpi_tables.c +++ b/src/mainboard/aopen/dxplplusu/acpi_tables.c @@ -20,6 +20,7 @@
#include <arch/acpi.h> #include <device/pci.h> +#include <device/pci_def.h>
#define IOAPIC_ICH4 2 #define IOAPIC_P64H2_BUS_B 3 /* IOAPIC 3 at 02:1c.0 */ diff --git a/src/mainboard/asrock/e350m1/irq_tables.c b/src/mainboard/asrock/e350m1/irq_tables.c index 9ebe58a..0bcb041 100644 --- a/src/mainboard/asrock/e350m1/irq_tables.c +++ b/src/mainboard/asrock/e350m1/irq_tables.c @@ -15,6 +15,7 @@
#include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/asrock/imb-a180/irq_tables.c b/src/mainboard/asrock/imb-a180/irq_tables.c index e18e478..be71dd4 100644 --- a/src/mainboard/asrock/imb-a180/irq_tables.c +++ b/src/mainboard/asrock/imb-a180/irq_tables.c @@ -15,6 +15,7 @@
#include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index 0bff4d7..1c27a0f 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -15,6 +15,7 @@ #include <cpu/cpu.h> #include <cpu/x86/lapic_def.h> #include <arch/io.h> +#include <device/pci_def.h> #include <device/pci_ops.h> #include <arch/ioapic.h> #include <stdint.h> diff --git a/src/mainboard/gizmosphere/gizmo/irq_tables.c b/src/mainboard/gizmosphere/gizmo/irq_tables.c index ca30cc7..bf2379c 100644 --- a/src/mainboard/gizmosphere/gizmo/irq_tables.c +++ b/src/mainboard/gizmosphere/gizmo/irq_tables.c @@ -16,6 +16,7 @@
#include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/pcengines/apu1/irq_tables.c b/src/mainboard/pcengines/apu1/irq_tables.c index 9ebe58a..0bcb041 100644 --- a/src/mainboard/pcengines/apu1/irq_tables.c +++ b/src/mainboard/pcengines/apu1/irq_tables.c @@ -15,6 +15,7 @@
#include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/pcengines/apu2/irq_tables.c b/src/mainboard/pcengines/apu2/irq_tables.c index f7302ba..2c93401 100644 --- a/src/mainboard/pcengines/apu2/irq_tables.c +++ b/src/mainboard/pcengines/apu2/irq_tables.c @@ -15,6 +15,7 @@
#include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h>
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37843 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37843 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37843 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
mainboard: Add missing include <device/pci_def.h>
Change-Id: I8a7c989540e8b62de7fd291f695adac849f4680c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37843 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/amd/gardenia/irq_tables.c M src/mainboard/aopen/dxplplusu/acpi_tables.c M src/mainboard/asrock/e350m1/irq_tables.c M src/mainboard/asrock/imb-a180/irq_tables.c M src/mainboard/emulation/qemu-i440fx/northbridge.c M src/mainboard/gizmosphere/gizmo/irq_tables.c M src/mainboard/pcengines/apu1/irq_tables.c M src/mainboard/pcengines/apu2/irq_tables.c 8 files changed, 8 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Werner Zeh: Looks good to me, approved
diff --git a/src/mainboard/amd/gardenia/irq_tables.c b/src/mainboard/amd/gardenia/irq_tables.c index bf1daec..3af2757 100644 --- a/src/mainboard/amd/gardenia/irq_tables.c +++ b/src/mainboard/amd/gardenia/irq_tables.c @@ -15,6 +15,7 @@
#include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/aopen/dxplplusu/acpi_tables.c b/src/mainboard/aopen/dxplplusu/acpi_tables.c index cc6835b..70bfa27 100644 --- a/src/mainboard/aopen/dxplplusu/acpi_tables.c +++ b/src/mainboard/aopen/dxplplusu/acpi_tables.c @@ -20,6 +20,7 @@
#include <arch/acpi.h> #include <device/pci.h> +#include <device/pci_def.h>
#define IOAPIC_ICH4 2 #define IOAPIC_P64H2_BUS_B 3 /* IOAPIC 3 at 02:1c.0 */ diff --git a/src/mainboard/asrock/e350m1/irq_tables.c b/src/mainboard/asrock/e350m1/irq_tables.c index 9ebe58a..0bcb041 100644 --- a/src/mainboard/asrock/e350m1/irq_tables.c +++ b/src/mainboard/asrock/e350m1/irq_tables.c @@ -15,6 +15,7 @@
#include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/asrock/imb-a180/irq_tables.c b/src/mainboard/asrock/imb-a180/irq_tables.c index e18e478..be71dd4 100644 --- a/src/mainboard/asrock/imb-a180/irq_tables.c +++ b/src/mainboard/asrock/imb-a180/irq_tables.c @@ -15,6 +15,7 @@
#include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index 0bff4d7..1c27a0f 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -15,6 +15,7 @@ #include <cpu/cpu.h> #include <cpu/x86/lapic_def.h> #include <arch/io.h> +#include <device/pci_def.h> #include <device/pci_ops.h> #include <arch/ioapic.h> #include <stdint.h> diff --git a/src/mainboard/gizmosphere/gizmo/irq_tables.c b/src/mainboard/gizmosphere/gizmo/irq_tables.c index ca30cc7..bf2379c 100644 --- a/src/mainboard/gizmosphere/gizmo/irq_tables.c +++ b/src/mainboard/gizmosphere/gizmo/irq_tables.c @@ -16,6 +16,7 @@
#include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/pcengines/apu1/irq_tables.c b/src/mainboard/pcengines/apu1/irq_tables.c index 9ebe58a..0bcb041 100644 --- a/src/mainboard/pcengines/apu1/irq_tables.c +++ b/src/mainboard/pcengines/apu1/irq_tables.c @@ -15,6 +15,7 @@
#include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/pcengines/apu2/irq_tables.c b/src/mainboard/pcengines/apu2/irq_tables.c index f7302ba..2c93401 100644 --- a/src/mainboard/pcengines/apu2/irq_tables.c +++ b/src/mainboard/pcengines/apu2/irq_tables.c @@ -15,6 +15,7 @@
#include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h>
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Werner Zeh (Code Review)