Attention is currently required from: Marc Jones, Martin Roth, Arthur Heymans, Patrick Rudolph.
Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49913 )
Change subject: soc/intel/xeon_sp/cpx: Move soc_final to finalize.c
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/xeon_sp/cpx/finalize.c:
https://review.coreboot.org/c/coreboot/+/49913/comment/65acff6c_e1803686
PS1, Line 21: pci_or_config32(pcidev_path_on_root(PCI_DEVFN(0, 0)), 0x80, 1 << 0);
I know this code is simply being moved. But now is a good time to clean it up also. I recommend using #defines for register offsets and bit settings.
https://review.coreboot.org/c/coreboot/+/49913/comment/1fa966ff_57d29d8f
PS1, Line 41:
We should do this on BS_ON_ENTRY, which means just before the PAYLOAD is loaded into memory.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49913
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c3319cbbfc44e6232033e9d7f299f45d9f22b07
Gerrit-Change-Number: 49913
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 26 Jan 2021 22:29:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment