Attention is currently required from: Carlos López, Maximilian Brune, Philipp Hug, ron minnich.
Joel Bueno has posted comments on this change by Joel Bueno. ( https://review.coreboot.org/c/coreboot/+/85800?usp=email )
Change subject: commonlib/device_tree: fix 64-bit misaligned member access ......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4: Added a secondary change to actually add the FDT parsing for Spike target: https://review.coreboot.org/c/coreboot/+/86588/1
This one is to fix one of the issues we found for RV when doing so.
Commit Message:
https://review.coreboot.org/c/coreboot/+/85800/comment/7ceb6170_86ac0e01?usp... : PS3, Line 16: his does not happen on qemu because, for that target, we parse the : FDT instead of manually probing memory.
Its your choice, but you might as well re-use this patch.
Acknowledged
https://review.coreboot.org/c/coreboot/+/85800/comment/269f5e9a_3e0aa45e?usp... : PS3, Line 19: TEST=boot verified on SPIKE-RISCV
Could you also add the cmdline of spike that you tested with? (makes it easier to reproduce).
Done